Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Change the name of ListInDisk #47777

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Oct 19, 2023

What problem does this PR solve?

Issue Number: ref #47733

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 19, 2023
@tiprow
Copy link

tiprow bot commented Oct 19, 2023

Hi @xzhangxian1008. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008
Copy link
Contributor Author

/cc @guo-shaoge

@ti-chi-bot ti-chi-bot bot requested a review from guo-shaoge October 19, 2023 06:12
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #47777 (af2623e) into master (90bd2dd) will increase coverage by 1.1253%.
Report is 8 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47777        +/-   ##
================================================
+ Coverage   71.8537%   72.9791%   +1.1253%     
================================================
  Files          1398       1423        +25     
  Lines        405209     413310      +8101     
================================================
+ Hits         291158     301630     +10472     
+ Misses        94396      92853      -1543     
+ Partials      19655      18827       -828     
Flag Coverage Δ
integration 41.5889% <50.0000%> (?)
unit 72.0486% <100.0000%> (+0.1948%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7905% <ø> (-4.1606%) ⬇️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guo-shaoge, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [guo-shaoge,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 19, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 19, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-19 06:26:57.5769242 +0000 UTC m=+1897615.164034337: ☑️ agreed by hawkingrei.
  • 2023-10-19 06:37:32.728147327 +0000 UTC m=+1898250.315257472: ☑️ agreed by guo-shaoge.

@xzhangxian1008
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Oct 20, 2023

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Oct 20, 2023

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xzhangxian1008 xzhangxian1008 mentioned this pull request Oct 20, 2023
13 tasks
@xzhangxian1008
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Oct 20, 2023

@xzhangxian1008: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 3c461dd into pingcap:master Oct 20, 2023
14 of 16 checks passed
@xzhangxian1008 xzhangxian1008 deleted the change-disk-name branch October 23, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants