Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Fix compression protocol for larger packets | tidb-test=pr/2227 #47495

Merged
merged 15 commits into from
Nov 3, 2023
Merged

server: Fix compression protocol for larger packets | tidb-test=pr/2227 #47495

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8069715
server: Fix compression protocol for larger packets
dveeden Oct 9, 2023
82bc509
Add test: TestPacketIOWriteCompressed
dveeden Oct 10, 2023
96760b6
Update bazel build
dveeden Oct 10, 2023
2edce7f
Merge remote-tracking branch 'upstream/master' into compress_16m
dveeden Oct 12, 2023
569088e
Merge remote-tracking branch 'upstream/master' into compress_16m
dveeden Oct 16, 2023
8644e61
server: Avoid overreading compressed packets
dveeden Oct 16, 2023
0cf92f0
Improve error message for invalid sequence
dveeden Oct 20, 2023
ad380ec
Merge remote-tracking branch 'upstream/master' into compress_16m
dveeden Oct 20, 2023
686d461
Use io.Reader interface for compressed protocol
dveeden Oct 20, 2023
6281cc5
Fix issues found by CI
dveeden Oct 20, 2023
0f43948
Add tests for compressed reader
dveeden Oct 22, 2023
bec37b6
Cleanup commented out code
dveeden Oct 22, 2023
bac39af
Fix ineffectual assignment to err
dveeden Oct 22, 2023
38bfe26
Merge remote-tracking branch 'upstream/master' into compress_16m
dveeden Nov 2, 2023
ee66779
Sync sequence like MySQL does
dveeden Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions server/internal/packetio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,11 +256,7 @@ func (p *PacketIO) ReadPacket() ([]byte, error) {
func (p *PacketIO) WritePacket(data []byte) error {
length := len(data) - 4
server_metrics.WritePacketBytes.Add(float64(len(data)))

maxPayloadLen := mysql.MaxPayloadLen
if p.compressionAlgorithm != mysql.CompressionNone {
maxPayloadLen -= 4
}

for length >= maxPayloadLen {
data[3] = p.sequence
Expand Down