Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, tests: migrate tests for plan_cache into the integrationtest #47443

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Oct 8, 2023

What problem does this PR solve?

Issue Number: close #47173

Problem Summary:

This is the last part of migrating tests in planner.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

@YangKeao YangKeao added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 8, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 8, 2023
@YangKeao
Copy link
Member Author

YangKeao commented Oct 8, 2023

/check-issue-triage-complete

@YangKeao
Copy link
Member Author

YangKeao commented Oct 8, 2023

/retest

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #47443 (f966a4c) into master (34cc339) will increase coverage by 0.4344%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47443        +/-   ##
================================================
+ Coverage   72.2845%   72.7190%   +0.4344%     
================================================
  Files          1352       1373        +21     
  Lines        401072     407412      +6340     
================================================
+ Hits         289913     296266      +6353     
- Misses        91940      92351       +411     
+ Partials      19219      18795       -424     
Flag Coverage Δ
integration 39.2816% <ø> (?)
unit 72.1516% <ø> (-0.1330%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.6574% <ø> (-0.0971%) ⬇️
br 48.8594% <ø> (-4.3354%) ⬇️

@YangKeao
Copy link
Member Author

YangKeao commented Oct 8, 2023

/retest

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-08 06:57:36.263992134 +0000 UTC m=+949053.851102280: ☑️ agreed by hawkingrei.
  • 2023-10-08 06:59:37.1421261 +0000 UTC m=+949174.729236229: ☑️ agreed by qw4990.

@ti-chi-bot ti-chi-bot bot merged commit 8772821 into pingcap:master Oct 8, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move IT in planner/ to explaintest, files number 81
3 participants