Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disttask: fix upgrade #47316

Merged
merged 1 commit into from
Sep 27, 2023
Merged

disttask: fix upgrade #47316

merged 1 commit into from
Sep 27, 2023

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Sep 27, 2023

What problem does this PR solve?

Issue Number: ref #47311 close #47299

Problem Summary:

What is changed and how it works?

Forget to call upgradeToVer176

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ywqzzy ywqzzy requested a review from a team as a code owner September 27, 2023 04:03
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 27, 2023
@tiprow
Copy link

tiprow bot commented Sep 27, 2023

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #47316 (dee2fcb) into master (99d9d41) will increase coverage by 0.2312%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47316        +/-   ##
================================================
+ Coverage   72.5647%   72.7959%   +0.2312%     
================================================
  Files          1348       1370        +22     
  Lines        401100     407752      +6652     
================================================
+ Hits         291057     296827      +5770     
- Misses        90941      92074      +1133     
+ Partials      19102      18851       -251     
Flag Coverage Δ
integration 36.8041% <ø> (?)
unit 72.6626% <ø> (+0.0979%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.8837% <ø> (+0.0107%) ⬆️
br 48.7550% <ø> (-4.2785%) ⬇️

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Sep 27, 2023

/test all

@tiprow
Copy link

tiprow bot commented Sep 27, 2023

@ywqzzy: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 27, 2023
@lance6716
Copy link
Contributor

/cherry-pick release-7.4

@ti-chi-bot
Copy link
Member

@lance6716: once the present PR merges, I will cherry-pick it on top of release-7.4 in the new PR and assign it to you.

In response to this:

/cherry-pick release-7.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor

/check-issue-triage-complete

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-27 05:22:11.994065614 +0000 UTC m=+425121.712407832: ☑️ agreed by Benjamin2037.
  • 2023-09-27 05:30:33.451811641 +0000 UTC m=+425623.170153857: ☑️ agreed by bb7133.

@lance6716
Copy link
Contributor

/hold

need to test #47318 before we fix the problem 😂

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@easonn7
Copy link

easonn7 commented Sep 27, 2023

/approve

There is no sysvar change.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, Benjamin2037, easonn7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2023
@lance6716
Copy link
Contributor

/unhold

I'll test my PR after manually change related code

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit 789adfc into pingcap:master Sep 27, 2023
15 of 16 checks passed
@ti-chi-bot
Copy link
Member

@lance6716: new pull request created to branch release-7.4: #47323.

In response to this:

/cherry-pick release-7.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 27, 2023
13 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tidb_global_task_history not create for upgrade tidb
6 participants