-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: add OWNERS
file
#47134
br: add OWNERS
file
#47134
Conversation
Fixes pingcap#47130 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Skipping CI for Draft Pull Request. |
Hi @wuhuizuo. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold It need tests for full config with a default regex route. |
/cc BornChanger 3pointer YuJuncen Leavrth /cc sig-critical-approvers-tidb-lightning |
@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: Leavrth, BornChanger. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc sig-critical-approvers-tidb-lightning |
/approve There is no sysvar change. |
I think https://github.com/pingcap/tidb/tree/master/br/pkg/lightning can be excluded. https://github.com/pingcap/tidb/tree/master/br/pkg/storage can be jointly maintained |
@okJiang Thanks! I will create another PR to add |
/unhold It's solved.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, easonn7, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here |
[LGTM Timeline notifier]Timeline:
|
Also note that |
Next PR for br/pkg/lightning is coming. |
Fixes #47130
What problem does this PR solve?
Issue Number: close #47130
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.
/type enhancement
/component br