Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: add OWNERS file #47134

Merged
merged 1 commit into from
Sep 27, 2023
Merged

br: add OWNERS file #47134

merged 1 commit into from
Sep 27, 2023

Conversation

wuhuizuo
Copy link
Contributor

Fixes #47130

What problem does this PR solve?

Issue Number: close #47130

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

/type enhancement
/component br

Fixes pingcap#47130

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
@tiprow
Copy link

tiprow bot commented Sep 20, 2023

Hi @wuhuizuo. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor Author

/hold

It need tests for full config with a default regex route.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@wuhuizuo wuhuizuo marked this pull request as ready for review September 20, 2023 09:41
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2023
@wuhuizuo
Copy link
Contributor Author

/cc BornChanger 3pointer YuJuncen Leavrth

/cc sig-critical-approvers-tidb-lightning
for approving on OWNERS file.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: Leavrth, BornChanger.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc BornChanger 3pointer YuJuncen Leavrth

/cc sig-critical-approvers-tidb-lightning
for approving on OWNERS file.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor Author

/cc sig-critical-approvers-tidb-lightning

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2023
@easonn7
Copy link

easonn7 commented Sep 20, 2023

/approve

There is no sysvar change.

@okJiang
Copy link
Member

okJiang commented Sep 21, 2023

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 26, 2023

I think https://github.com/pingcap/tidb/tree/master/br/pkg/lightning can be excluded. https://github.com/pingcap/tidb/tree/master/br/pkg/storage can be jointly maintained

@okJiang Thanks! I will create another PR to add OWNERS file into br/pkg/lightning folder, it's in task lists #46911

@wuhuizuo
Copy link
Contributor Author

/unhold

It's solved.

/hold

It need tests for full config with a default regex route.

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, easonn7, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-20 10:00:13.369526476 +0000 UTC m=+684379.337114511: ☑️ agreed by BornChanger.
  • 2023-09-27 07:44:39.668214562 +0000 UTC m=+1477.255324708: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 1404a9c into pingcap:master Sep 27, 2023
17 of 28 checks passed
@YuJuncen
Copy link
Contributor

YuJuncen commented Sep 27, 2023

Also note that lightning is still in br/pkg, will this give all br folks the permission in tidb-lightning?

@wuhuizuo
Copy link
Contributor Author

Also note that lightning is still in br/pkg, will this give all br forks the permission in tidb-lightning?

Next PR for br/pkg/lightning is coming.

@wuhuizuo wuhuizuo deleted the wuhuizuo/issue47130 branch September 27, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add OWNERS file for br folder
5 participants