-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add resource group name when dispatch req to tiflash #47096
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
This reverts commit 5c1baca.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47096 +/- ##
================================================
- Coverage 72.9633% 72.5884% -0.3749%
================================================
Files 1337 1359 +22
Lines 399007 407048 +8041
================================================
+ Hits 291129 295470 +4341
- Misses 89075 92848 +3773
+ Partials 18803 18730 -73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@guo-shaoge: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/merge |
@guo-shaoge: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@guo-shaoge: We have migrated to builtin Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #47093
Problem Summary:
What is changed and how it works?
This is part of tiflash resource control.
Add resource group name to cop/batchCop/MPP req when dispatching to tiflash.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.