Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add resource group name when dispatch req to tiflash #47096

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

guo-shaoge
Copy link
Collaborator

@guo-shaoge guo-shaoge commented Sep 19, 2023

What problem does this PR solve?

Issue Number: close #47093

Problem Summary:

What is changed and how it works?

This is part of tiflash resource control.
Add resource group name to cop/batchCop/MPP req when dispatching to tiflash.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. setup tidb cluster with one or more tiflash instances
  2. run following sqls:
create resource group rg1 ru_per_sec = 1000 burstable = false;
create resource group rg2 ru_per_sec = 1000 burstable = false;
create resource group rg3 ru_per_sec = 1000 burstable = false;

set tidb_allow_mpp=0;
set @@tidb_allow_tiflash_cop = 1;
set @@tidb_allow_batch_cop = 0;
explain analyze select /*+ resource_group(rg1) */ * from t1;

set tidb_allow_mpp=0;
set @@tidb_allow_tiflash_cop = 1;
set @@tidb_allow_batch_cop = 2;
explain analyze select /*+ resource_group(rg2) */ * from t1;
  1. check tiflash log, we can see resource group is added, so tiflash resource control will work as expected.

5DhMOvlGKe
6kXh2R8KNw
FrbflSexwi

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 19, 2023
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #47096 (1e61794) into master (4450ae4) will decrease coverage by 0.3749%.
Report is 11 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #47096        +/-   ##
================================================
- Coverage   72.9633%   72.5884%   -0.3749%     
================================================
  Files          1337       1359        +22     
  Lines        399007     407048      +8041     
================================================
+ Hits         291129     295470      +4341     
- Misses        89075      92848      +3773     
+ Partials      18803      18730        -73     
Flag Coverage Δ
integration 30.6944% <0.0000%> (?)
unit 73.0142% <100.0000%> (+0.0508%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9728% <ø> (ø)
br 48.6542% <ø> (-4.2856%) ⬇️

@tiprow
Copy link

tiprow bot commented Sep 19, 2023

@guo-shaoge: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test 1e61794 link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@guo-shaoge
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-20 03:07:10.298675658 +0000 UTC m=+659596.266263691: ☑️ agreed by wshwsh12.
  • 2023-09-20 06:12:08.900713566 +0000 UTC m=+670694.868301601: ☑️ agreed by XuHuaiyu.

@guo-shaoge
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

@guo-shaoge: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@guo-shaoge
Copy link
Collaborator Author

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

@guo-shaoge: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 3f3b07e into pingcap:master Sep 20, 2023
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable tiflash resource control
3 participants