Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: fix register_test failed error for flaky test #46991

Merged
merged 8 commits into from
Feb 7, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Sep 14, 2023

What problem does this PR solve?

Issue Number: close #46848

Problem Summary:
the unit test failed in the flaky test

What is changed and how it works?

fix the unit test

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-tests-checked size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Sep 14, 2023
@tiprow
Copy link

tiprow bot commented Sep 14, 2023

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #46991 (62611ca) into master (ebe334f) will increase coverage by 10.1783%.
Report is 321 commits behind head on master.
The diff coverage is 50.0000%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #46991         +/-   ##
=================================================
+ Coverage   71.9162%   82.0946%   +10.1783%     
=================================================
  Files          1439       2495       +1056     
  Lines        346158     683695     +337537     
=================================================
+ Hits         248944     561277     +312333     
- Misses        76967     101431      +24464     
- Partials      20247      20987        +740     
Flag Coverage Δ
integration 49.0067% <ø> (?)
unit 79.4409% <50.0000%> (+7.5246%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 73.6130% <ø> (+17.3001%) ⬆️
parser ∅ <ø> (∅)
br 72.2794% <50.0000%> (+20.8079%) ⬆️

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@hawkingrei
Copy link
Member

/test all

1 similar comment
@hawkingrei
Copy link
Member

/test all

Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 7, 2024
Copy link

ti-chi-bot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 7, 2024
Copy link

ti-chi-bot bot commented Feb 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-07 06:36:35.913456083 +0000 UTC m=+338721.480225968: ☑️ agreed by YuJuncen.
  • 2024-02-07 08:08:00.760385575 +0000 UTC m=+344206.327155465: ☑️ agreed by 3pointer.

Copy link

tiprow bot commented Feb 7, 2024

@Leavrth: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tidb_parser_test 62611ca link true /test tidb_parser_test
tiprow_fast_test 62611ca link true /test tiprow_fast_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit dee790b into pingcap:master Feb 7, 2024
32 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test TestTaskRegisterFailedGrant
4 participants