Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: Escape object in show grants output | tidb-test=pr/2217 #46976

Merged
merged 10 commits into from
Sep 20, 2023
Merged

executor: Escape object in show grants output | tidb-test=pr/2217 #46976

merged 10 commits into from
Sep 20, 2023

Conversation

sunxiaoguang
Copy link
Contributor

@sunxiaoguang sunxiaoguang commented Sep 14, 2023

What problem does this PR solve?

Issue Number: close #46975

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked do-not-merge/needs-triage-completed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2023
@tiprow
Copy link

tiprow bot commented Sep 14, 2023

Hi @sunxiaoguang. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #46976 (7881541) into master (21db64f) will decrease coverage by 0.9062%.
Report is 24 commits behind head on master.
The diff coverage is 80.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #46976        +/-   ##
================================================
- Coverage   73.1015%   72.1953%   -0.9062%     
================================================
  Files          1335       1357        +22     
  Lines        398034     410550     +12516     
================================================
+ Hits         290969     296398      +5429     
- Misses        88336      95450      +7114     
+ Partials      18729      18702        -27     
Flag Coverage Δ
integration 30.9274% <0.0000%> (?)
unit 73.0934% <80.0000%> (-0.0081%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <ø> (ø)
parser 84.9872% <ø> (-0.0108%) ⬇️
br 48.2584% <ø> (-4.6460%) ⬇️

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@sunxiaoguang sunxiaoguang changed the title [WIP] executor: Escape object in show grants output [WIP] executor: Escape object in show grants output | tidb-test=pr/2217 Sep 15, 2023
@sunxiaoguang
Copy link
Contributor Author

/retest

@tiprow
Copy link

tiprow bot commented Sep 15, 2023

@sunxiaoguang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 15, 2023
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-tests-checked labels Sep 15, 2023
@sunxiaoguang
Copy link
Contributor Author

/test mysql-test

@tiprow
Copy link

tiprow bot commented Sep 15, 2023

@sunxiaoguang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
@sunxiaoguang
Copy link
Contributor Author

/test check-dev

@tiprow
Copy link

tiprow bot commented Sep 15, 2023

@sunxiaoguang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunxiaoguang
Copy link
Contributor Author

/test mysql-test

@tiprow
Copy link

tiprow bot commented Sep 15, 2023

@sunxiaoguang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunxiaoguang
Copy link
Contributor Author

/test mysql-test

@tiprow
Copy link

tiprow bot commented Sep 16, 2023

@sunxiaoguang: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 16, 2023
@sunxiaoguang
Copy link
Contributor Author

/test mysql-test

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2023

@tiancaiamao: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tiancaiamao
Copy link
Contributor

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. and removed do-not-merge/needs-triage-completed labels Sep 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6271d1c into pingcap:master Sep 20, 2023
11 of 16 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #47106.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 20, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #47107.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 20, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #47108.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 20, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #47109.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 20, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #47110.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 20, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@djshow832 djshow832 removed needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show grants should quote database name
6 participants