importinto: add metrics and dashboard #46749
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46749 +/- ##
================================================
- Coverage 73.3707% 72.8789% -0.4918%
================================================
Files 1326 1348 +22
Lines 396691 403904 +7213
================================================
+ Hits 291055 294361 +3306
- Misses 87092 90948 +3856
- Partials 18544 18595 +51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/retest |
| var ctxKey ctxKeyType | ||
| var ( | ||
| allMetricKey ctxKeyType = "all-metrics" | ||
| commonMetricKey ctxKeyType = "common-metrics" |
There was a problem hiding this comment.
it's very similar to common. let's wait other reviewer's opinions
|
/retest |
ti-chi-bot
bot
added
needs-1-more-lgtm
| @@ -220,6 +221,10 @@ func (dsp *importDispatcherExt) OnNextStage(ctx context.Context, handle dispatch | |||
| var nextStep int64 | |||
| switch gTask.Step { | |||
| case proto.StepInit: | |||
| if metrics, ok := metric.GetCommonMetric(ctx); ok { | |||
There was a problem hiding this comment.
Why not add this counter when generating the taskMeta.Plan?
There was a problem hiding this comment.
you mean on creating task? we only want this metric after the task start running
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/retest |
What problem does this PR solve?
Issue Number: ref #46704
Problem Summary:
What is changed and how it works?
add metrics and dashboard for import into tasks to help monitor and diagnose.
Check List
Tests
some board last longer than others as it's calculating rate in a time window
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.