Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix wrong result for unsigned non-const int cmp const duration (#46620) #46700

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46620

What problem does this PR solve?

Issue Number: close #45410

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Sep 6, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels Sep 6, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 6, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 6, 2023
@wshwsh12 wshwsh12 force-pushed the cherry-pick-46620-to-release-5.4 branch from 79e18a5 to f116b4e Compare September 7, 2023 06:47
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 11, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-11 07:02:50.257139247 +0000 UTC m=+252752.181695641: ☑️ agreed by xhebox.
  • 2023-09-12 02:16:51.911270456 +0000 UTC m=+321993.835826851: ☑️ agreed by hawkingrei.

@wshwsh12
Copy link
Contributor

/run-unit-test

3 similar comments
@wshwsh12
Copy link
Contributor

/run-unit-test

@wshwsh12
Copy link
Contributor

/run-unit-test

@wshwsh12
Copy link
Contributor

/run-unit-test

@wshwsh12
Copy link
Contributor

/run-unit-test

6 similar comments
@wshwsh12
Copy link
Contributor

/run-unit-test

@wshwsh12
Copy link
Contributor

/run-unit-test

@wshwsh12
Copy link
Contributor

/run-unit-test

@wshwsh12
Copy link
Contributor

/run-unit-test

@wshwsh12
Copy link
Contributor

/run-unit-test

@zanmato1984
Copy link
Contributor

/run-unit-test

@wshwsh12
Copy link
Contributor

/retest

@wshwsh12
Copy link
Contributor

/build
/run-unit-test

@wshwsh12
Copy link
Contributor

/run-unit-test

@purelind
Copy link
Contributor

/run-build

@ti-chi-bot ti-chi-bot bot merged commit 472fa31 into pingcap:release-5.4 Oct 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants