-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global sort: support setting cloud storage uri variable #46407
Conversation
Hi @lichunzhu. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46407 +/- ##
================================================
- Coverage 73.2928% 72.7954% -0.4975%
================================================
Files 1322 1346 +24
Lines 396399 403046 +6647
================================================
+ Hits 290532 293399 +2867
- Misses 87336 91069 +3733
- Partials 18531 18578 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sessionctx/variable/sysvar.go
Outdated
@@ -2227,6 +2227,17 @@ var defaultSysVars = []*SysVar{ | |||
DDLDiskQuota.Store(TidbOptUint64(val, DefTiDBDDLDiskQuota)) | |||
return nil | |||
}}, | |||
{Scope: ScopeSession, Name: TiDBGlobalSortURI, Value: "", Type: TypeStr, Validation: func(sv *SessionVars, normalizedValue string, originalValue string, scope ScopeFlag) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only session scope? The usability could be bad because it will be reset to "" every time a new session is created.
sessionctx/variable/sysvar.go
Outdated
} | ||
return normalizedValue, nil | ||
}, GetSession: func(sv *SessionVars) (string, error) { | ||
return sv.GlobalSortURI, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need add mask function to hide ak sk information?
@tangenta @Benjamin2037 PTAL again. I add a manual test in PR description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/retest |
@lichunzhu: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@lichunzhu: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/test all |
/retest |
1 similar comment
/retest |
/test unit-test |
@wjhuang2016: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/retest |
/retest |
1 similar comment
/retest |
sessionctx/variable/sysvar.go
Outdated
@@ -26,6 +26,7 @@ import ( | |||
"time" | |||
|
|||
"github.com/pingcap/errors" | |||
"github.com/pingcap/tidb/br/pkg/storage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use the RedactURL
in parser/ast/misc.go
instead?
/retest |
2 similar comments
/retest |
/retest |
What problem does this PR solve?
Issue Number: ref #45719
Problem Summary:
What is changed and how it works?
support setting global sort uri variable
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.