domain: use dedicated lock for expiredTimeStamp4PC (#45802) #46211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
ok-to-test
12 tasks
ti-chi-bot
added
the
cherry-pick-approved
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
force-pushed
the
cherry-pick-45802-to-release-6.5
branch
from
cddf047
to
14669af
Compare
Signed-off-by: Jack Yu <jackysp@gmail.com>
ti-chi-bot
bot
added
needs-1-more-lgtm
jackysp
approved these changes
Aug 18, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, jackysp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46211 +/- ##
================================================
Coverage ? 73.6931%
================================================
Files ? 1084
Lines ? 347951
Branches ? 0
================================================
Hits ? 256416
Misses ? 75082
Partials ? 16453 |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #45802
What problem does this PR solve?
Issue Number: close #45400
What is changed and how it works?
Added a dedicated lock for domain.expiredTimeStamp4PC so it doesn't share the lock with domain, therefore schema reload (domain.Reload()) won't be blocked by comipler.Compile().
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.