*: replace the util/intest package with Go1.21 testing.Testing() #46194

tiancaiamao · 2023-08-17T12:00:49Z

What problem does this PR solve?

Issue Number: close #43630

Problem Summary:

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

tiprow · 2023-08-17T12:01:16Z

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov · 2023-08-17T12:13:58Z

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.

Project coverage is 27.6388%. Comparing base (75fa815) to head (75936ea).
Report is 3037 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (75fa815) and HEAD (75936ea). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (75fa815) HEAD (75936ea)

unit 1 0

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #46194         +/-   ##
=================================================
- Coverage   73.3060%   27.6388%   -45.6673%     
=================================================
  Files          1321       1187        -134     
  Lines        396195     351502      -44693     
=================================================
- Hits         290435      97151     -193284     
- Misses        87247     242853     +155606     
+ Partials      18513      11498       -7015

Flag	Coverage Δ
integration	`27.6388% <15.6250%> (?)`
unit	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`∅ <ø> (∅)`
parser	`∅ <ø> (∅)`
br	`0.1081% <ø> (-52.5020%)`	⬇️

tiancaiamao · 2023-08-18T07:14:49Z

/retest-required

hawkingrei · 2023-08-18T10:55:51Z

/test all

hawkingrei · 2023-08-18T10:56:08Z

/ok-to-test

ti-chi-bot · 2023-08-18T11:00:13Z

[LGTM Timeline notifier]

Timeline:

2023-08-18 09:29:09.740929338 +0000 UTC m=+882514.289945324: ☑️ agreed by xhebox.
2023-08-18 11:00:12.413495706 +0000 UTC m=+887976.962511678: ☑️ agreed by hawkingrei.

hawkingrei · 2023-08-18T12:40:37Z

/retest

tiancaiamao · 2023-08-18T14:29:06Z

/retest-required

tiancaiamao · 2023-08-19T15:51:34Z

/test tiprow_fast_test

ti-chi-bot · 2023-08-19T15:51:37Z

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-mysql-connector-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pull-notify-when-compatibility-sections-changed

In response to this:

/test tiprow_fast_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiancaiamao · 2023-08-21T03:58:00Z

PTAL @yudongusa @easonn7

tiancaiamao · 2023-08-21T05:48:26Z

/retest-required

wuhuizuo · 2023-08-22T06:50:54Z

/retest

some flaky test cases broken the testing.

yudongusa

LGTM since the QA team did the full tests.

ti-chi-bot · 2023-09-06T02:50:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, xhebox, yudongusa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hawkingrei,xhebox]
~~session/OWNERS~~ [yudongusa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiancaiamao · 2023-09-07T08:14:55Z

/test check_dev

ti-chi-bot · 2023-09-07T08:14:57Z

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test canary-scan-security
/test check-dev
/test check-dev2
/test mysql-test
/test pingcap/tidb/canary_ghpr_unit_test
/test pull-br-integration-test
/test pull-common-test
/test pull-e2e-test
/test pull-integration-common-test
/test pull-integration-copr-test
/test pull-integration-ddl-test
/test pull-integration-jdbc-test
/test pull-integration-mysql-test
/test pull-integration-prisma-test
/test pull-mysql-connector-test
/test pull-sqllogic-test
/test pull-tiflash-test
/test unit-test

The following commands are available to trigger optional jobs:

/test pull-notify-when-compatibility-sections-changed

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build
pingcap/tidb/ghpr_check
pingcap/tidb/ghpr_check2
pingcap/tidb/ghpr_mysql_test
pingcap/tidb/ghpr_unit_test
pull-notify-when-compatibility-sections-changed

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2023-09-07T08:15:31Z

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check_dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiancaiamao · 2023-09-08T03:31:42Z

/ok-to-test

tiancaiamao · 2023-09-08T04:30:23Z

/test check-dev2
/test unit-test

tiprow · 2023-09-08T04:30:57Z

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test check-dev2
/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiancaiamao · 2023-09-08T07:05:53Z

/test unit-test

tiprow · 2023-09-08T07:06:26Z

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiancaiamao · 2023-09-08T14:21:27Z

After I trigger build of the failed package, the test pass. So I think my guess is right, the CI does not rebuild the correct package with tags, and it use a staled package...

tiancaiamao · 2023-09-08T14:22:00Z

/test unit-test

tiprow · 2023-09-08T14:22:32Z

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiancaiamao · 2023-09-08T14:23:00Z

But how to fix it?
Do I need to trigger the rebuild of the packages one by one, by modify each package and commit again?

tiancaiamao · 2023-09-08T16:07:15Z

/test unit-test

tiprow · 2023-09-08T16:07:46Z

@tiancaiamao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test tiprow_fast_test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wuhuizuo · 2023-09-22T03:26:06Z

/retest

ti-chi-bot · 2023-11-17T15:51:36Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiprow · 2024-02-27T10:44:12Z

@tiancaiamao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
tiprow_fast_test	`75936ea`	link	true	`/test fast_test_tiprow`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ti-chi-bot · 2024-07-31T10:15:18Z

@tiancaiamao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-integration-ddl-test	`75936ea`	link	true	`/test pull-integration-ddl-test`
idc-jenkins-ci-tidb/build	`75936ea`	link	true	`/test build`
pull-mysql-client-test	`75936ea`	link	true	`/test pull-mysql-client-test`
idc-jenkins-ci-tidb/check_dev_2	`75936ea`	link	true	`/test check-dev2`
idc-jenkins-ci-tidb/check_dev	`75936ea`	link	true	`/test check-dev`
idc-jenkins-ci-tidb/mysql-test	`75936ea`	link	true	`/test mysql-test`
idc-jenkins-ci-tidb/unit-test	`75936ea`	link	true	`/test unit-test`
pull-lightning-integration-test	`75936ea`	link	true	`/test pull-lightning-integration-test`
pull-br-integration-test	`75936ea`	link	true	`/test pull-br-integration-test`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tiancaiamao added 2 commits August 17, 2023 19:38

*: replace the util/intest package with Go1.21 testing.Testing()

28a1fab

make bazel_prepare

840bb68

tiancaiamao requested a review from a team as a code owner August 17, 2023 12:00

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 17, 2023

fix build

2f8c0cf

tiancaiamao requested review from hawkingrei and xhebox August 18, 2023 09:24

xhebox approved these changes Aug 18, 2023

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 18, 2023

ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 18, 2023

hawkingrei approved these changes Aug 18, 2023

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 18, 2023

hawkingrei removed the request for review from a team August 18, 2023 11:04

yudongusa approved these changes Sep 6, 2023

View reviewed changes

Merge branch 'master' into intest

655a5a6

Merge branch 'master' into intest

39ebb09

tiancaiamao added 4 commits September 8, 2023 20:33

try to workaround TestExtensionStmtEvents

f4d40dd

replace server.RunInTest with testing.Testing()

edb66bc

fix build

e5e7189

try to trigger rebuild, I suspect CI use the wrong package cache

3c033e5

tiancaiamao added 3 commits September 8, 2023 22:33

add log to debug in the CI env

2d83d19

bazel does not handle testing.Testing() well?

d113bd9

another try

57a8e26

tiancaiamao mentioned this pull request Sep 8, 2023

support Go1.21 testing.Testing() function bazel-contrib/rules_go#3686

Open

another place...

75936ea

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: replace the util/intest package with Go1.21 testing.Testing() #46194

*: replace the util/intest package with Go1.21 testing.Testing() #46194

tiancaiamao commented Aug 17, 2023

tiprow bot commented Aug 17, 2023

codecov bot commented Aug 17, 2023 •

edited

Loading

tiancaiamao commented Aug 18, 2023

hawkingrei commented Aug 18, 2023

hawkingrei commented Aug 18, 2023

ti-chi-bot bot commented Aug 18, 2023

hawkingrei commented Aug 18, 2023

tiancaiamao commented Aug 18, 2023

tiancaiamao commented Aug 19, 2023

ti-chi-bot bot commented Aug 19, 2023

tiancaiamao commented Aug 21, 2023

tiancaiamao commented Aug 21, 2023

wuhuizuo commented Aug 22, 2023

yudongusa left a comment

ti-chi-bot bot commented Sep 6, 2023

tiancaiamao commented Sep 7, 2023

ti-chi-bot bot commented Sep 7, 2023

tiprow bot commented Sep 7, 2023

tiancaiamao commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiprow bot commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiprow bot commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiprow bot commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiprow bot commented Sep 8, 2023

wuhuizuo commented Sep 22, 2023

ti-chi-bot bot commented Nov 17, 2023

tiprow bot commented Feb 27, 2024

ti-chi-bot bot commented Jul 31, 2024

*: replace the util/intest package with Go1.21 testing.Testing() #46194

Are you sure you want to change the base?

*: replace the util/intest package with Go1.21 testing.Testing() #46194

Conversation

tiancaiamao commented Aug 17, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

tiprow bot commented Aug 17, 2023

codecov bot commented Aug 17, 2023 • edited Loading

Codecov Report

tiancaiamao commented Aug 18, 2023

hawkingrei commented Aug 18, 2023

hawkingrei commented Aug 18, 2023

ti-chi-bot bot commented Aug 18, 2023

[LGTM Timeline notifier]

hawkingrei commented Aug 18, 2023

tiancaiamao commented Aug 18, 2023

tiancaiamao commented Aug 19, 2023

ti-chi-bot bot commented Aug 19, 2023

tiancaiamao commented Aug 21, 2023

tiancaiamao commented Aug 21, 2023

wuhuizuo commented Aug 22, 2023

yudongusa left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Sep 6, 2023

tiancaiamao commented Sep 7, 2023

ti-chi-bot bot commented Sep 7, 2023

tiprow bot commented Sep 7, 2023

tiancaiamao commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiprow bot commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiprow bot commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiprow bot commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiancaiamao commented Sep 8, 2023

tiprow bot commented Sep 8, 2023

wuhuizuo commented Sep 22, 2023

ti-chi-bot bot commented Nov 17, 2023

tiprow bot commented Feb 27, 2024

ti-chi-bot bot commented Jul 31, 2024

codecov bot commented Aug 17, 2023 •

edited

Loading