Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store,server: Reduce TiFlashFallBack test time #45778

Merged
merged 3 commits into from
Aug 3, 2023
Merged

store,server: Reduce TiFlashFallBack test time #45778

merged 3 commits into from
Aug 3, 2023

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Aug 3, 2023

What problem does this PR solve?

Issue Number: close #45773

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2023
@tiprow
Copy link

tiprow bot commented Aug 3, 2023

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Aug 3, 2023

/cc @hawkingrei @wshwsh12

@hawkingrei
Copy link
Member

/ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Aug 3, 2023
Signed-off-by: yibin <huyibin@pingcap.com>
Signed-off-by: yibin <huyibin@pingcap.com>
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #45778 (913b3b6) into master (412fa13) will increase coverage by 0.0181%.
Report is 5 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #45778        +/-   ##
================================================
+ Coverage   73.3314%   73.3496%   +0.0181%     
================================================
  Files          1271       1274         +3     
  Lines        392954     393631       +677     
================================================
+ Hits         288159     288727       +568     
- Misses        86415      86489        +74     
- Partials      18380      18415        +35     
Flag Coverage Δ
integration 78.1388% <ø> (?)
unit 73.3414% <100.0000%> (+0.0099%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.0444% <ø> (ø)
parser 85.0359% <ø> (-0.0109%) ⬇️
br 52.0297% <ø> (+0.0313%) ⬆️

@hawkingrei
Copy link
Member

/retest

2 similar comments
@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/retest

@hawkingrei
Copy link
Member

/test all

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 3, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-03 02:39:53.986109256 +0000 UTC m=+325877.928457788: ☑️ agreed by hawkingrei.
  • 2023-08-03 02:50:59.036925275 +0000 UTC m=+326542.979273803: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit 20490ae into pingcap:master Aug 3, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestTiFlashFallback took too long
3 participants