Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap_restore: resend recover_region while there are TiKV restarts (#45361) #45721

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45361

What problem does this PR solve?

Issue Number: close #45206

Problem Summary:
When TiKV restarts, the leaders will be dropped here.

What is changed and how it works?

We need to reregister the leaders.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fixed a bug that may cause snapshot restore stuck while there are TiKV restarts.

YuJuncen and others added 10 commits August 1, 2023 10:22
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 1, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 1, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 1, 2023
@YuJuncen
Copy link
Contributor

YuJuncen commented Aug 2, 2023

/retest-required

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@3fe36d8). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #45721   +/-   ##
================================================
  Coverage               ?   73.6883%           
================================================
  Files                  ?       1083           
  Lines                  ?     347112           
  Branches               ?          0           
================================================
  Hits                   ?     255781           
  Misses                 ?      74896           
  Partials               ?      16435           

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 2, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-01 15:39:08.189280344 +0000 UTC m=+199832.131628872: ☑️ agreed by BornChanger.
  • 2023-08-02 06:51:59.614765123 +0000 UTC m=+254603.557113653: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 503ab42 into pingcap:release-6.5 Aug 2, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants