-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disttask: refine dispatcher #45460
disttask: refine dispatcher #45460
Conversation
Hi @ywqzzy. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #45460 +/- ##
================================================
+ Coverage 73.1995% 73.2185% +0.0190%
================================================
Files 1265 1270 +5
Lines 390142 391401 +1259
================================================
+ Hits 285582 286578 +996
- Misses 86243 86434 +191
- Partials 18317 18389 +72
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
} | ||
|
||
func (d *dispatcher) Inited() bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use this function. Could we remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Inited
is better for checking of the dispatcher is started.
cancel context.CancelFunc | ||
taskMgr *storage.TaskManager | ||
wg tidbutil.WaitGroupWrapper | ||
gPool *spool.Pool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does gpool do now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does gpool do now?
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// ExecuteTask start to schedule a task | ||
func (d *dispatcher) ExecuteTask() { | ||
// Using the pool with block, so it wouldn't return an error. | ||
_ = d.gPool.Run(func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about move to dispatcher manager?
func (dm *DispatcherManager) StartDispathcer(){
dm.gPool.Run(func() {
d := newDispatcher()
d.ExecuteTask()
d.delRunningTask()
})
}
Then we no need finished channel.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, GMHDBJD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #41495
Problem Summary:
Currently, the
dispatcher
use 2 for loop to dispatch and monitor tasks.There is no abstraction for
dispatcher
anddispatcherManager
.dispatcher
only handles one task.dispatcherManager
manages a bunch ofdispatcher
s and transfer submitted tasks to differentdispatcher
s.What is changed and how it works?
DetectTaskLoop
.DispatchTaskLoop
, make it as light weight as possible.monitorTask
which monitor the task status.scheduleTask
which will call schedule one task with a for loop.executeTask
interface which will trigger one goroutine to call scheduleTask.Abstract
dispatcher
struct which only schedule and execute one task.dispatcher
will provide interface like:scheduleTask
: schedules the execution of subtasks.monitorTask
: check if the step is finished.GenerateDistPlan
: generate the task plan.The
dispatcher
do the following job step by step:Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.