Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix error information when enter incorrect partition name #45078

Merged

Conversation

River2000i
Copy link
Contributor

@River2000i River2000i commented Jun 30, 2023

What problem does this PR solve?

Issue Number: close #44967

Problem Summary: remove incorrect partition name in error information when enter incorrect partition name

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Jun 30, 2023
@sre-bot
Copy link
Contributor

sre-bot commented Jun 30, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2023
@tiprow
Copy link

tiprow bot commented Jun 30, 2023

Hi @River2000i. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@River2000i
Copy link
Contributor Author

/test all

@tiprow
Copy link

tiprow bot commented Jun 30, 2023

@River2000i: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@River2000i River2000i closed this Jun 30, 2023
@River2000i River2000i reopened this Jun 30, 2023
@River2000i
Copy link
Contributor Author

/test all

@tiprow
Copy link

tiprow bot commented Jun 30, 2023

@River2000i: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@River2000i
Copy link
Contributor Author

/test pull-br-integration-test

@tiprow
Copy link

tiprow bot commented Jul 7, 2023

@River2000i: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 13, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-13 05:54:44.062488035 +0000 UTC m=+570575.832826749: ☑️ agreed by Defined2014.
  • 2023-07-13 06:03:51.577509054 +0000 UTC m=+571123.347847766: ☑️ agreed by xhebox.

@Defined2014
Copy link
Contributor

/test all

@tiprow
Copy link

tiprow bot commented Jul 13, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hawkingrei
Copy link
Member

/test all

@Defined2014
Copy link
Contributor

@River2000i It seems that there is a problem with ci, you can merge master and push again

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Jul 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 13, 2023

@River2000i: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-br-integration-test cea3c26 link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Defined2014
Copy link
Contributor

/test unit-test

@tiprow
Copy link

tiprow bot commented Jul 13, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 2af9a67 into pingcap:master Jul 13, 2023
@River2000i River2000i deleted the fix-check-partition-name-error-trace branch July 13, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad error string in Incorrect partition name
5 participants