-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix cte miss cleaning spilled-disk file (#44501) #44529
Merged
ti-chi-bot
merged 7 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-44501-to-release-6.5
Jun 9, 2023
Merged
*: fix cte miss cleaning spilled-disk file (#44501) #44529
ti-chi-bot
merged 7 commits into
pingcap:release-6.5
from
ti-chi-bot:cherry-pick-44501-to-release-6.5
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
12 tasks
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jun 8, 2023
ti-chi-bot
bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
do-not-merge/cherry-pick-not-approved
labels
Jun 8, 2023
ti-chi-bot
added
the
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
label
Jun 8, 2023
/test check-dev2 |
XuHuaiyu
approved these changes
Jun 9, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Jun 9, 2023
VelocityLight
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 9, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
cherry-pick-approved
Cherry pick PR approved by release team.
do-not-merge/cherry-pick-not-approved
labels
Jun 9, 2023
VelocityLight
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 9, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 9, 2023
VelocityLight
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 9, 2023
VelocityLight
added
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 9, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 9, 2023
VelocityLight
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 9, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 9, 2023
VelocityLight
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 9, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
and removed
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 9, 2023
VelocityLight
added
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
cherry-pick-approved
Cherry pick PR approved by release team.
labels
Jun 9, 2023
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
cherry-pick-approved
Cherry pick PR approved by release team.
and removed
do-not-merge/cherry-pick-not-approved
labels
Jun 9, 2023
ti-chi-bot
removed
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 14, 2023
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-6.5
This PR is cherry-picked to release-6.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #44501
What problem does this PR solve?
Issue Number: close #44477
Problem Summary:
Close record set for select stmt and insert/update stmt is in different code path.
Miss calling
resetCTEStorage
for insert/update stmt, whose recordSet is nil.What is changed and how it works?
resetCTEStorage()
in handleNoDelay(), this will cover insert/update.. DML stmt.resetCTEStorage() in
(a *ExecStmt) CloseRecordSet`, this will cover select stmt. Also for prepare/execute/plan cache/select for update.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.