Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix load data assertion failure #43858

Merged
merged 2 commits into from
May 16, 2023
Merged

executor: fix load data assertion failure #43858

merged 2 commits into from
May 16, 2023

Conversation

you06
Copy link
Contributor

@you06 you06 commented May 16, 2023 •
edited by zyguan
Loading

What problem does this PR solve?

Issue Number: close #43849

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

you06 added 2 commits May 15, 2023 16:39
@you06
wip
9fc40c3 
Signed-off-by: you06 <you1474600@gmail.com>
@you06
add tests
cd1d1ff 
Signed-off-by: you06 <you1474600@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YangKeao
  • zyguan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 16, 2023
YangKeao
YangKeao approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 16, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 16, 2023
@you06
Copy link
Contributor Author

you06 commented May 16, 2023

/merge

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 16, 2023

This pull request has been accepted and is ready to merge.

Commit hash: cd1d1ff

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 16, 2023
@ti-chi-bot ti-chi-bot bot merged commit 04aef00 into pingcap:release-6.5 May 16, 2023
@zyguan zyguan mentioned this pull request Jun 16, 2023
Closed
you06 added a commit to you06/tidb that referenced this pull request Aug 4, 2023
@you06
executor: fix load data assertion failure (pingcap#43858)
0a1f9a2 
close pingcap#43849
@you06 you06 mentioned this pull request Aug 4, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Aug 4, 2023
@you06
executor: fix load data assertion failure (#43858) (#45825)
6e593be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@zyguan zyguan zyguan approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@you06 @YangKeao @zyguan @VelocityLight