-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backup: check the store state by last heartbeat (#43099) #43217
backup: check the store state by last heartbeat (#43099) #43217
Conversation
Signed-off-by: hillium <yujuncen@pingcap.com>
Signed-off-by: hillium <yujuncen@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3247805
|
/test unit-test |
1 similar comment
/test unit-test |
/test unit-test
…On Tue, May 23, 2023 at 6:44 PM ti-chi-bot[bot] ***@***.***> wrote:
@ti-chi-bot <https://github.com/ti-chi-bot>: The following test *failed*,
say /retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 3247805
<3247805>
link
<https://do.pingcap.net/jenkins/job/pingcap/job/tidb/job/release-6.5/job/ghpr_unit_test/769/display/redirect>
true /test unit-test
Full PR test history
<https://prow.tidb.net/pr-history?org=pingcap&repo=tidb&pr=43217>. Your
PR dashboard
<https://prow.tidb.net/pr?query=is%3Apr%20state%3Aopen%20author%3Ati-chi-bot>
.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
Reply to this email directly, view it on GitHub
<#43217 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIUPNKP5DQZITP2PBTO7VKDXHSIJ3ANCNFSM6AAAAAAXEHIT34>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
/retest |
This is an automated cherry-pick of #43099
What problem does this PR solve?
Issue Number: close #42973
Problem Summary:
The current implementation cannot detect whether a store is down. So it keeps retry sending request to an offline store.
What is changed and how it works?
This PR checks the
LastHeartbeatTS
of the store and give up to request the store once the gap is greater than 20s (also defined in the PD package.)Check List
Tests
Backup over a cluster with one node down, finished in reasonable time.
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.