Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: load resource unit config from local pd client #43097

Merged
merged 6 commits into from
Apr 19, 2023
Merged

resource_control: load resource unit config from local pd client #43097

merged 6 commits into from
Apr 19, 2023

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Apr 17, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #38825

Problem Summary:

What is changed and how it works?

  • Fetch the request-units configs from local resource-control client instead of executing a show config query to avoid the requiring of SYSTEM_VARIABLES_ADMIN privilege.
  • Add a check of tidb_enable_resource_control before execute calibrate resource

NOTE:
Currently, this PR put the pd-client ResourceGroupController under the executor package, I think this is not a very good idea but I can't find a better place. Maybe we should put all resource-group related logic into a separate package.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 17, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2023
HuSharp
HuSharp reviewed Apr 17, 2023
View reviewed changes
executor/calibrate_resource.go Outdated
}

// resource_ctl is the ResourceGroupController in pd client
resource_ctl *rmclient.ResourceGroupsController
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need Camel-Case

HuSharp
HuSharp reviewed Apr 17, 2023
View reviewed changes
executor/calibrate_resource.go Outdated

// GetResourceGroupController returns the ResourceGroupsController.
func GetResourceGroupController() *rmclient.ResourceGroupsController {
return resourceGrooupCtl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra o

@glorv
Copy link
Contributor Author

glorv commented Apr 17, 2023

/retest

2 similar comments
@HuSharp
Copy link
Contributor

HuSharp commented Apr 17, 2023

/retest

@glorv
Copy link
Contributor Author

glorv commented Apr 18, 2023

/retest

HuSharp
HuSharp approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@HuSharp: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@HuSharp
Copy link
Contributor

HuSharp commented Apr 18, 2023

/retest

@glorv
Copy link
Contributor Author

glorv commented Apr 18, 2023

/test

@ti-chi-bot
Copy link
Member

@glorv: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test unit-test

Use /test all to run all jobs.

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@glorv
Copy link
Contributor Author

glorv commented Apr 18, 2023

/retest

nolouch
nolouch approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, do you ensure the METRICS_SCHEMA can be accessed?

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2023
@glorv
Copy link
Contributor Author

glorv commented Apr 18, 2023

LGTM. BTW, do you ensure the METRICS_SCHEMA can be accessed?

@nolouch I have added privileges requirements in the docs. See: pingcap/docs-cn#13714

@nolouch nolouch requested a review from JmPotato April 19, 2023 07:08
@nolouch
Copy link
Member

nolouch commented Apr 19, 2023

PTAL @JmPotato

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2023
@glorv
Copy link
Contributor Author

glorv commented Apr 19, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 39ca750

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2023
@ti-chi-bot ti-chi-bot merged commit fc5392e into pingcap:master Apr 19, 2023
@glorv glorv deleted the calibrate-permission branch December 15, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch nolouch approved these changes

@HuSharp HuSharp HuSharp approved these changes

@BornChanger BornChanger Awaiting requested review from BornChanger

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@glorv @ti-chi-bot @HuSharp @nolouch @JmPotato