Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: lock untouched unique keys on update #42713

Merged
merged 2 commits into from
Mar 31, 2023
Merged

executor: lock untouched unique keys on update #42713

merged 2 commits into from
Mar 31, 2023

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Mar 30, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #36438

Problem Summary: Only row keys will be locked after updates (without changing handle), which leads to #36438. We tried to solve the issue by #36498, however it has been reverted because of the issue of accumulated locks. Since the optimizition described in tikv/tikv#13694 is done, we can now solve the issue again.

What is changed and how it works?

Also collect untouched unique keys and lock them.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zyguan
executor: lock untouched unique keys on update
b8c071d 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@zyguan zyguan requested a review from a team as a code owner March 30, 2023 10:41
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 30, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • cfzjywxk
  • ekexium

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 30, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 30, 2023
ekexium
ekexium approved these changes Mar 31, 2023
View reviewed changes
sessionctx/variable/session.go Outdated
// AddUnchangedRowKey adds an unchanged row key in update statement for pessimistic lock.
func (tc *TransactionContext) AddUnchangedRowKey(key []byte) {
// AddUnchangedKeyForLock adds an unchanged key for pessimistic lock.
func (tc *TransactionContext) AddUnchangedKeyForLock(key []byte) {
if tc.unchangedRowKeys == nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable name and comments needs to be changed as well.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 31, 2023
@zyguan
address the comment
5bd81fe 
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@zyguan
Copy link
Contributor Author

zyguan commented Mar 31, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5bd81fe

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 31, 2023
@zyguan
Copy link
Contributor Author

zyguan commented Mar 31, 2023

/retest

2 similar comments
@zyguan
Copy link
Contributor Author

zyguan commented Mar 31, 2023

/retest

@cfzjywxk
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot merged commit e6cf1ab into pingcap:master Mar 31, 2023
@zyguan zyguan mentioned this pull request May 23, 2023
Closed
@ekexium ekexium mentioned this pull request Jun 15, 2023
Closed
@jackysp jackysp mentioned this pull request Jul 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfzjywxk cfzjywxk cfzjywxk approved these changes

@ekexium ekexium ekexium approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@you06 you06 Awaiting requested review from you06

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unique key lock not consistent when row is changed or not
4 participants
@zyguan @ti-chi-bot @cfzjywxk @ekexium