Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: skip automatically get bucket region with other s3 compatible provider. #41889

Merged
merged 10 commits into from
Mar 30, 2023
Merged

br: skip automatically get bucket region with other s3 compatible provider. #41889

merged 10 commits into from
Mar 30, 2023

Conversation

3pointer
Copy link
Contributor

@3pointer 3pointer commented Mar 3, 2023 •
edited by Leavrth
Loading

What problem does this PR solve?

Issue Number: close #41916 close #42033

Problem Summary:

Skip auto get bucket region when user didn't use aws s3 provider.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 3, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • BornChanger
  • Leavrth

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 3, 2023
@3pointer 3pointer changed the title br: support skip automatically get bucket region with other s3 compat… br: skip automatically get bucket region with other s3 compatible provider. Mar 3, 2023
@3pointer 3pointer marked this pull request as ready for review March 3, 2023 10:29
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2023
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2023
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2023
@ti-chi-bot
Copy link
Member

@WangLe1321: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2023
@dveeden
Copy link
Contributor

dveeden commented Mar 27, 2023

@3pointer could you resolve the conflicts and have a look at #42366 to see what the best way is to get this fixed?

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 27, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 30, 2023
@3pointer
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 957916e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 30, 2023
@ti-chi-bot ti-chi-bot merged commit 0a08f64 into pingcap:master Mar 30, 2023
@3pointer 3pointer added affects-6.5 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Apr 12, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 12, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #42968.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Apr 12, 2023
@3pointer @ti-chi-bot
This is an automated cherry-pick of pingcap#41889
02953c7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
D3Hunter pushed a commit that referenced this pull request May 8, 2023
@3pointer @D3Hunter
br: skip automatically get bucket region with other s3 compatible pro…
0574875 
…vider. (#41889)

close #41916, close #42033
ti-chi-bot bot pushed a commit that referenced this pull request Jul 4, 2023
@ti-chi-bot
br: skip automatically get bucket region with other s3 compatible pro…
09da01c 
…vider. (#41889) (#42968)

close #41916, close #42033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangLe1321 WangLe1321 WangLe1321 approved these changes

@Leavrth Leavrth Leavrth approved these changes

@BornChanger BornChanger BornChanger approved these changes

Assignees
No one assigned
Labels
affects-6.5 needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@3pointer @ti-chi-bot @dveeden @WangLe1321 @Leavrth @BornChanger