executor: fix IndexMergeReaderExecutor hang when to exit #41560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
ti-chi-bot
added
do-not-merge/needs-triage-completed
and removed
do-not-merge/needs-linked-issue
labels
hawkingrei
added
skip-issue-check
|
/check-issue-triage-complete |
hawkingrei
removed
the
skip-issue-check
guo-shaoge
reviewed
Feb 20, 2023
| @@ -360,12 +360,12 @@ func (e *IndexMergeReaderExecutor) startPartialIndexWorker(ctx context.Context, | |||
| SetPaging(e.paging). | |||
| SetFromInfoSchema(e.ctx.GetInfoSchema()). | |||
| SetClosestReplicaReadAdjuster(newClosestReadAdjuster(e.ctx, &builder.Request, e.partialNetDataSizes[workID])) | |||
|
|
|||
| forLabel: | |||
There was a problem hiding this comment.
Maybe open another issue.
XuHuaiyu
reviewed
Feb 21, 2023
ti-chi-bot
added
needs-cherry-pick-release-5.3
|
Will fix here #41633 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #41545
Problem Summary:
What is changed and how it works?
It is found at #41306.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.