Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, store/copr: allow limit on range partitioned table #41342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

you06
Copy link
Contributor

@you06 you06 commented Feb 13, 2023

Signed-off-by: you06 you1474600@gmail.com

What problem does this PR solve?

Issue Number: ref #41480

Problem Summary:

Currently we when there is order by xx limit n statement over a partitioned table, and the xx is the partitioned PK, we still use a TopN plan which read across all related partitions, but there is a chance to stop earlier when the partition type is range.

What is changed and how it works?

Use a limit plan when the table is range partitioned.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Support limit on range partitioned table, which speeds up limit-n statements.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 13, 2023
@you06 you06 force-pushed the copr/limit-on-range-partition branch from 031ef90 to 599b7fd Compare February 13, 2023 12:49
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 13, 2023
@you06 you06 force-pushed the copr/limit-on-range-partition branch from 599b7fd to 16ed0e0 Compare February 13, 2023 12:55
@hawkingrei
Copy link
Member

/retest

@you06
Copy link
Contributor Author

you06 commented Feb 13, 2023

It's not unstable, the test need to be fixed due to this PR's update.

Signed-off-by: you06 <you1474600@gmail.com>
@you06 you06 force-pushed the copr/limit-on-range-partition branch from 2748ea8 to 7f4fe22 Compare February 14, 2023 07:35
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Feb 14, 2023
@ti-chi-bot
Copy link
Member

@you06: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -2080,8 +2080,8 @@ func (ds *DataSource) convertToTableScan(prop *property.PhysicalProperty, candid
task = copTask
if candidate.isMatchProp {
copTask.keepOrder = true
// TableScan on partition table can't keep order.
if ds.tableInfo.GetPartitionInfo() != nil {
// TableScan on partition table can't keep order, except range partition.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the partition key is not the row id key?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table schema:
primary key a
partition by b

query:
order by b limit
order by a limit

@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Dec 19, 2023
Copy link

ti-chi-bot bot commented Apr 10, 2024

@you06: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 7f4fe22 link true /test mysql-test
pull-integration-ddl-test 7f4fe22 link true /test pull-integration-ddl-test
pull-mysql-client-test 7f4fe22 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/unit-test 7f4fe22 link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 7f4fe22 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 7f4fe22 link true /test check-dev
idc-jenkins-ci-tidb/build 7f4fe22 link true /test build
pull-br-integration-test 7f4fe22 link true /test pull-br-integration-test
pull-lightning-integration-test 7f4fe22 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants