Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: remove the useless part #40967

Closed

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Feb 2, 2023

What problem does this PR solve?

Issue Number: related to #40945

Problem Summary:
We don't support the order_index for the index hint and only support the comment style. So remove the useless part.

What is changed and how it works?

We don't support the order_index for the index hint. So remove the useless part.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Reminiscent Reminiscent added skip-issue-check Indicates that a PR no need to check linked issue. epic/hint labels Feb 2, 2023
@Reminiscent Reminiscent requested review from qw4990 and fzzf678 February 2, 2023 03:35
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2023
@ti-chi-bot
Copy link
Member

@Reminiscent: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 54bfb18 link true /test check-dev2
idc-jenkins-ci-tidb/check_dev 54bfb18 link true /test check-dev
idc-jenkins-ci-tidb/unit-test 54bfb18 link true /test unit-test
idc-jenkins-ci-tidb/mysql-test 54bfb18 link true /test mysql-test
idc-jenkins-ci-tidb/build 54bfb18 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Reminiscent Reminiscent closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic/hint release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants