-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizer: add test cases for predicate simplifications. #40774
Optimizer: add test cases for predicate simplifications. #40774
Conversation
…ady covered and some are not
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ghazalfamilyusa: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ahmad Ghazal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@ghazalfamilyusa: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
Issue Number: ref #40221
Problem Summary:
This PR just adds tests of various predicate simplification optimizations cases. The purpose of the test is to
(1) document existing cases. This include (a) removing redundancy for identical simple predicates
like =, <>, > and <, >= and <=, (b) un-satisfiable conditions like x=1 and x <> 1 (c) intersection of two in lists.
(2) list cases not working currently and should be addressed in future optimizations. These cases cover
the use case in #40221) and more like intersection of two "not in" lists.
(3) establish a place holder for predicate simplification is a general optimizer rewrite rule and sub-rules.
Tests
Side effects: None
Documentation: Noting needed
Release note
None