Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix risk of OOM #40443

Merged
merged 10 commits into from
Jan 12, 2023
Merged

lightning: fix risk of OOM #40443

merged 10 commits into from
Jan 12, 2023

Conversation

buchuitoudegou
Copy link
Contributor

@buchuitoudegou buchuitoudegou commented Jan 10, 2023 •
edited
Loading

What problem does this PR solve?

The risk of OOM when importing large data file
Issue Number: close #40400

Problem Summary:

What is changed and how it works?

  • check if the buf has exceeded the max length of transaction

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 10, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/invalid-title release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2023
@buchuitoudegou buchuitoudegou changed the title L oom lightning: fix risk of OOM Jan 10, 2023
@buchuitoudegou
Copy link
Contributor Author

/component lightning

@ti-chi-bot ti-chi-bot added the component/lightning This issue is related to Lightning of TiDB. label Jan 10, 2023
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2023
@buchuitoudegou
Copy link
Contributor Author

/cc @gozssky

@buchuitoudegou
Copy link
Contributor Author

/test unit-test

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 10, 2023
@buchuitoudegou
Copy link
Contributor Author

/cc @lance6716

wait for BR's CI fixed.

lance6716
lance6716 approved these changes Jan 10, 2023
View reviewed changes
br/pkg/lightning/mydump/csv_parser_test.go Outdated
var testCase bytes.Buffer
testCase.WriteString("a,b,c,d")
// WARN: will take up 120MB memory here.
for i := 0; i < tidbconfig.MaxTxnEntrySizeLimit; i++ {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe create a variable in init so we can easily test it. Not sure if CI can tolerate this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd6e96e

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dc59781

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 10, 2023
@buchuitoudegou
Copy link
Contributor Author

/run-integration-br-test

1 similar comment
@buchuitoudegou
Copy link
Contributor Author

/run-integration-br-test

@buchuitoudegou
Copy link
Contributor Author

/retest

@buchuitoudegou buchuitoudegou added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2023
@buchuitoudegou
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 760aae8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 12, 2023
@ti-chi-bot
Copy link
Member

@buchuitoudegou: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit fb29c80 into pingcap:master Jan 12, 2023
lance6716 pushed a commit to lance6716/tidb that referenced this pull request Jun 1, 2023
@buchuitoudegou @ti-chi-bot @lance6716
lightning: fix risk of OOM (pingcap#40443)
bf8c7b5 
* fix: check buf size

* fix: terminate too long buf

* add ut

* fix dev

* local var

* fix ut

* fix lint

* fix lint

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@lance6716 lance6716 mentioned this pull request Jun 1, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 1, 2023
@lance6716
lightning: fix risk of OOM (#40443) (#44333)
bb2e845 
close #40400
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 30, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 30, 2023
@ti-chi-bot
lightning: fix risk of OOM (#40443) (#44333) (#45072)
5e0977a 
close #40400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@sleepymole sleepymole sleepymole approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lightning: risk of OOM
4 participants
@buchuitoudegou @ti-chi-bot @lance6716 @sleepymole