-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Adding tidb_enable_plan_cache_with_dynamic_prune_mode #40436
*: Adding tidb_enable_plan_cache_with_dynamic_prune_mode #40436
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
…c-prune-mode-v6.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mjonss: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@mjonss: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…c-prune-mode-v6.5
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 177635f
|
It's only a patch version, so approved.Seems like there are some issues in UT, maybe need take a look. @mjonss |
What problem does this PR solve?
Issue Number: ref #33031
Problem Summary:
Enable plan cache when tidb_partition_prune_mode = dynamic
What is changed and how it works?
Adding a new system variable (both global and session) tidb_enable_plan_cache_with_dynamic_prune_mode = <on|off>
to allow testing even when #33031 is not fixed.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.