Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: Adding telemetry for alter table reorganize partition #40258

Merged
merged 4 commits into from
Jan 18, 2023
Merged

telemetry: Adding telemetry for alter table reorganize partition #40258

merged 4 commits into from
Jan 18, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Dec 30, 2022

What problem does this PR solve?

Issue Number: ref #38535

Problem Summary:
Missing telemetry for new reorganize partition feature

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 30, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2022
@mjonss mjonss mentioned this pull request Dec 30, 2022
Closed
13 tasks
xhebox
xhebox approved these changes Jan 3, 2023
View reviewed changes
executor/adapter.go
@@ -194,7 +194,7 @@ type TelemetryInfo struct {
UseNonRecursive bool
UseRecursive bool
UseMultiSchemaChange bool
UesExchangePartition bool
UseExchangePartition bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 3, 2023
mjonss
mjonss commented Jan 4, 2023
View reviewed changes
metrics/telemetry.go
@@ -269,6 +276,7 @@ type TablePartitionUsageCounter struct {
TablePartitionAddIntervalPartitionsCnt int64 `json:"table_partition_add_interval_partitions_cnt"`
TablePartitionDropIntervalPartitionsCnt int64 `json:"table_partition_drop_interval_partitions_cnt"`
TablePartitionComactCnt int64 `json:"table_TablePartitionComactCnt"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not really part of this PR) Can this be changed to TablePartitionCompactCnt / table_TablePartitionComactCnt (adding a 'p' Comact -> Compact)? Since the json is already defined.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess It is possible. But you need to contact the telemetry(observe) team to change the column name, and change how their HTTP api handles telemetry requests.

@mjonss
Copy link
Contributor Author

mjonss commented Jan 4, 2023

/retest

@mjonss mjonss changed the title telemetry: Adding telemetry for alter table reorganize partition telemetry: Adding telemetry for alter table reorganize partition | tidb-test=pr/2069 Jan 18, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Jan 18, 2023

/test mysql-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 18, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Jan 18, 2023

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 84bca8b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 18, 2023
@ti-chi-bot ti-chi-bot merged commit 8db6a00 into pingcap:feature/reorganize-partition Jan 18, 2023
@mjonss mjonss changed the title telemetry: Adding telemetry for alter table reorganize partition | tidb-test=pr/2069 telemetry: Adding telemetry for alter table reorganize partition Jan 18, 2023
This was referenced Jan 31, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@tangenta tangenta tangenta approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjonss @ti-chi-bot @xhebox @tangenta