-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
session: fix upgrade #40182
session: fix upgrade #40182
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@chrysan: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/test build |
/test unit-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 93798a1
|
/test unit-test |
/retest |
/merge |
/unhold |
/test unit-test |
1 similar comment
/test unit-test |
@@ -49,7 +49,7 @@ func TestMemoryLeak(t *testing.T) { | |||
runtime.ReadMemStats(&memStat) | |||
// before the fix, initAndCloseTiDB for 20 times will cost 900 MB memory, so we test for a quite loose upper bound. | |||
if syncutil.EnableDeadlock { | |||
require.Less(t, memStat.HeapInuse-oldHeapInUse, uint64(1100*units.MiB)) | |||
require.Less(t, memStat.HeapInuse-oldHeapInUse, uint64(1500*units.MiB)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failed several times. Discussed with @hawkingrei to increase this value now and find a better solution later.
Error: "1158316032" is not less than "1153433600"
Error: "1162543104" is not less than "1153433600"
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c08ab0e
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #41502
Problem Summary:
It's because https://github.com/pingcap/tidb/pull/40179/files. To make it work when upgrade from v6.5 to master, change the upgrade version.
And leave some version numbers for possible patches for v6.5.x
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.