Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix issue of execute prepared DML panic with foreign key cascade #39734

Merged
merged 11 commits into from
Dec 9, 2022
Merged

executor: fix issue of execute prepared DML panic with foreign key cascade #39734

merged 11 commits into from
Dec 9, 2022

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #39732

Problem Summary: Fix issue of execute prepared DML panic with foreign key cascade

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
init
b2950e8 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
fix test
3dc7f10 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
add test
2f4e5e4 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 7, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 7, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • time-and-fate
  • winoros

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2022
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Dec 7, 2022
@crazycs520
tiny refine
8bfa081 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
time-and-fate
time-and-fate reviewed Dec 8, 2022
View reviewed changes
planner/core/flat_plan.go Show resolved Hide resolved
planner/core/flat_plan.go Outdated Show resolved Hide resolved
planner/core/flat_plan.go Outdated Show resolved Hide resolved
planner/core/flat_plan.go Outdated Show resolved Hide resolved
crazycs520 and others added 4 commits December 8, 2022 13:03
@crazycs520 @time-and-fate
Update planner/core/flat_plan.go
2ece897 
Co-authored-by: Zhou Kunqin <25057648+time-and-fate@users.noreply.github.com>
@crazycs520 @time-and-fate
Update planner/core/flat_plan.go
f15b8ed 
Co-authored-by: Zhou Kunqin <25057648+time-and-fate@users.noreply.github.com>
@crazycs520
address comment
cecf18e 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
mv comment
3e3c814 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 8, 2022
@crazycs520
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 9, 2022
@winoros
Copy link
Member

winoros commented Dec 9, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aa02b57

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2022
@ti-chi-bot ti-chi-bot merged commit c19adff into pingcap:master Dec 9, 2022
@crazycs520 crazycs520 deleted the fk-plan-bug branch December 9, 2022 04:06
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 9, 2022
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #39782.

@sre-bot
Copy link
Contributor

sre-bot commented Dec 9, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 1, success 16, total 17 15 min New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 20 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 4 min 12 sec Existing failure
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 13 min Fixed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 42 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 32 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 25 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 9 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 43 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

execute prepared DML panic with foreign key cascade
5 participants
@crazycs520 @ti-chi-bot @winoros @sre-bot @time-and-fate