-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util, executor: fix the problem that GetDatumWithBuffer does set null #39675
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
executor/executor_test.go
Outdated
@@ -6309,3 +6309,57 @@ func TestIssue39211(t *testing.T) { | |||
tk.MustExec("set @@tidb_enable_null_aware_anti_join=true;") | |||
tk.MustQuery("select * from t where (a,b) not in (select a, b from s);").Check(testkit.Rows()) | |||
} | |||
|
|||
func TestIssue39618(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that this test is put into executor/issuetest
. Too many test cases were put into the executor folder. it will slow the performance of bazel test, especially when it meets a flaky test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, executor/issuetest is in existed at release-6.5
/merge |
This pull request has been accepted and is ready to merge. Commit hash: daad267
|
/merge |
In response to a cherrypick label: new pull request created: #39679. |
TiDB MergeCI notify✅ Well Done! New fixed [2] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #39618
Problem Summary:
When using buffer, the null flag of a Datum is not promised to be false. Thus we need to set the null flag in GetDatumWithBuffer
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.