-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sessionctx: move shardRand from TransactionContext to SessionVars to reduce allocation #39661
Conversation
…reduce allocation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-build |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f493bd4
|
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 594da9a
|
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
TransactionCtx is reset every time, so the
shardRand
is re-allocated everytime.tidb/sessionctx/variable/session.go
Lines 249 to 252 in 2ca37cb
Before the change:
After the change:
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.