Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: add unit tests for password validation #39540

Merged
merged 8 commits into from
Dec 1, 2022
Merged

util: add unit tests for password validation #39540

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79501fc
Add more test
CbcWestwolf Dec 1, 2022
de2769d
Merge branch 'master' into fix_validate_password
CbcWestwolf Dec 1, 2022
478c073
Merge branch 'master' into fix_validate_password
ti-chi-bot Dec 1, 2022
df5f1a1
Merge branch 'master' into fix_validate_password
hawkingrei Dec 1, 2022
e534df1
Merge branch 'master' into fix_validate_password
hawkingrei Dec 1, 2022
dc79d42
Merge branch 'master' into fix_validate_password
hawkingrei Dec 1, 2022
6432974
Merge branch 'master' into fix_validate_password
ti-chi-bot Dec 1, 2022
9891612
Merge branch 'master' into fix_validate_password
ti-chi-bot Dec 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion util/password-validation/password_validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func TestValidateDictionaryPassword(t *testing.T) {
mock.SessionVars = vars
vars.GlobalVarsAccessor = mock

err := mock.SetGlobalSysVar(context.Background(), variable.ValidatePasswordDictionary, "1234;5678;HIJK")
err := mock.SetGlobalSysVar(context.Background(), variable.ValidatePasswordDictionary, "abc;123;1234;5678;HIJK;中文测试;。，；！")
require.NoError(t, err)
testcases := []struct {
pwd string
Expand All @@ -41,6 +41,8 @@ func TestValidateDictionaryPassword(t *testing.T) {
{"abcd12345efg", false},
{"abcd123efghij", true},
{"abcd123efghijk", false},
{"abcd123efghij中文测试", false},
{"abcd123。，；！", false},
}
for _, testcase := range testcases {
ok, err := ValidateDictionaryPassword(testcase.pwd, &vars.GlobalVarsAccessor)
Expand Down Expand Up @@ -135,3 +137,39 @@ func TestValidatePasswordMediumPolicy(t *testing.T) {
require.NoError(t, err)
require.Equal(t, "", warn)
}

func TestValidatePassword(t *testing.T) {
sessionVars := variable.NewSessionVars(nil)
sessionVars.GlobalVarsAccessor = variable.NewMockGlobalAccessor4Tests()
sessionVars.GlobalVarsAccessor.(*variable.MockGlobalAccessor).SessionVars = sessionVars
sessionVars.User = &auth.UserIdentity{Username: "user", AuthUsername: "authuser"}

err := sessionVars.GlobalVarsAccessor.SetGlobalSysVar(context.Background(), variable.ValidatePasswordPolicy, "LOW")
require.NoError(t, err)
err = ValidatePassword(sessionVars, "1234")
require.Error(t, err)
err = ValidatePassword(sessionVars, "user1234")
require.Error(t, err)
err = ValidatePassword(sessionVars, "authuser1234")
require.Error(t, err)
err = ValidatePassword(sessionVars, "User1234")
require.NoError(t, err)

err = sessionVars.GlobalVarsAccessor.SetGlobalSysVar(context.Background(), variable.ValidatePasswordPolicy, "MEDIUM")
require.NoError(t, err)
err = ValidatePassword(sessionVars, "User1234")
require.Error(t, err)
err = ValidatePassword(sessionVars, "!User1234")
require.NoError(t, err)
err = ValidatePassword(sessionVars, "！User1234")
require.NoError(t, err)

err = sessionVars.GlobalVarsAccessor.SetGlobalSysVar(context.Background(), variable.ValidatePasswordPolicy, "STRONG")
require.NoError(t, err)
err = sessionVars.GlobalVarsAccessor.SetGlobalSysVar(context.Background(), variable.ValidatePasswordDictionary, "User")
require.NoError(t, err)
err = ValidatePassword(sessionVars, "!User1234")
require.Error(t, err)
err = ValidatePassword(sessionVars, "!ABcd1234")
require.NoError(t, err)
}