Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: skip compatibility check for the mysql.user table when restoring #39460

Merged
merged 17 commits into from
Dec 1, 2022
Merged

br: skip compatibility check for the mysql.user table when restoring #39460

merged 17 commits into from
Dec 1, 2022

Conversation

MoCuishle28
Copy link
Contributor

Signed-off-by: zhanggaoming gaoming.zhang@pingcap.com

What problem does this PR solve?

Issue Number: close #38785

Problem Summary:
TiDB changed mysql.user schema in higher version
e.g.,
version95 add a column User_attributes to mysql.user
version98 add a column Token_issuer to mysql.user

when restore 6.2.0 mysql.user to 6.4.0 will report :
Error: column count mismatch

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Manual Test

  • insert record into mysql.user in v5.1.0 cluster
  • run full backup
  • restore to v6.4.0 cluster
  • success

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix a bug that caused: When restoring a low-version system table to a high-version cluster, it fails due to missing columns.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3pointer
  • CbcWestwolf

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2022
@MoCuishle28
Copy link
Contributor Author

/component br

@ti-chi-bot ti-chi-bot added the component/br This issue is related to BR of TiDB. label Nov 29, 2022
@MoCuishle28 MoCuishle28 force-pushed the rs-user-tbl-simply branch 3 times, most recently from 7ed1a5d to ef0851e Compare November 30, 2022 01:37
CbcWestwolf
CbcWestwolf approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@CbcWestwolf CbcWestwolf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's comment a warning here like:

WARNING: There are some limitations on altering the schema of mysql.user table. Adding columns that are nullable or have default values is permitted. But operations like dropping or renaming columns may break the compatibility with BR.
REFERENCE ISSUE: #38785

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2022
@MoCuishle28
br: skip compatibility check for the mysql.user table when restoring
a27d988 
Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
@MoCuishle28
br: skip compatibility check for the mysql.user table when restoring
3c05699 
Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
@MoCuishle28
br: skip compatibility check for the mysql.user table when restoring
2b19a14 
Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
@MoCuishle28
br: skip compatibility check for the mysql.user table when restoring
c8862cc 
Signed-off-by: zhanggaoming <gaoming.zhang@pingcap.com>
@MoCuishle28 MoCuishle28 requested a review from a team as a code owner November 30, 2022 02:44
@MoCuishle28
Copy link
Contributor Author

Let's comment a warning here like:

WARNING: There are some limitations on altering the schema of mysql.user table. Adding columns that are nullable or have default values is permitted. But operations like dropping or renaming columns may break the compatibility with BR.
REFERENCE ISSUE: #38785

Done.

@MoCuishle28
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2022
@3pointer
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 24053aa

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2022
@MoCuishle28
Copy link
Contributor Author

/run-check-dev-2

@CbcWestwolf
Copy link
Member

PTAL @qw4990 @jackysp

lance6716
lance6716 approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve this "tide Pending — Not mergeable. PullRequest is missing sufficient approving GitHub review(s)"

@lance6716
Copy link
Contributor

Oh it's lacking tidb-configuration-reviewer

@3pointer
Copy link
Contributor

3pointer commented Dec 1, 2022

/run-all-tests

@3pointer
Copy link
Contributor

3pointer commented Dec 1, 2022

/run-check_dev_2

@MoCuishle28
Copy link
Contributor Author

/run-check-dev-2

1 similar comment
@MoCuishle28
Copy link
Contributor Author

/run-check-dev-2

@ti-chi-bot
Copy link
Member

@MoCuishle28: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit d3f7ec0 into pingcap:master Dec 1, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Dec 1, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/common-test 🟥 all 0 tests passed 2 min 45 sec New failing
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 39, total 40 25 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 19 min Fixed
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 6 min 4 sec Fixed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 6 min 34 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 24 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 43 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 4 min 5 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 24 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@BornChanger BornChanger mentioned this pull request Jul 30, 2024
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@3pointer 3pointer 3pointer approved these changes

@qw4990 qw4990 qw4990 approved these changes

@CbcWestwolf CbcWestwolf CbcWestwolf approved these changes

Assignees
No one assigned
Labels
component/br This issue is related to BR of TiDB. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BR: 6.2.0 system table mysql.user can't be restored to 6.4.0
7 participants
@MoCuishle28 @ti-chi-bot @3pointer @CbcWestwolf @lance6716 @sre-bot @qw4990