-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: forbid point get with select lock choose tiflash as datasource path #39388
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@@ -202,6 +202,9 @@ type PhysicalProperty struct { | |||
// RejectSort means rejecting the sort property from its children, but it only works for MPP tasks. | |||
// Non-MPP tasks do not care about it. | |||
RejectSort bool | |||
|
|||
// InLock indicates the Plan is under LogicalLock | |||
InLock bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need it in physical property? Is there any other better place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, use isUpdateRead
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do this just in the plan builder?
Signed-off-by: yisaer <disxiaofei@163.com> address the comment Signed-off-by: yisaer <disxiaofei@163.com>
I tended to check it during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@@ -7554,6 +7554,26 @@ func TestEnableTiFlashReadForWriteStmt(t *testing.T) { | |||
checkMpp(rs) | |||
} | |||
|
|||
func TestPointGetWithSelectLock(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not just a test for a primary key, a test for a unique key is also necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
/run-unit-test |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 38e1593
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@gengliqi: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9f5d8cd
|
TiDB MergeCI notify✅ Well Done! New fixed [1] after this pr merged.
|
What problem does this PR solve?
Issue Number: close #39344
Problem Summary:
What is changed and how it works?
forbid point get with select lock choose tiflash as datasource path
Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.