Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: properly handle existence checks for deleted records in temp index #39371

Merged
merged 22 commits into from
Nov 28, 2022
Merged

ddl: properly handle existence checks for deleted records in temp index #39371

merged 22 commits into from
Nov 28, 2022

Commits on Nov 24, 2022

  1. fix tempidx key check exist logic.

    @Benjamin2037
    Benjamin2037 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    bbb7c38 View commit details
    Browse the repository at this point in the history

  2. only check temp idnex key.

    @Benjamin2037
    Benjamin2037 committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    ab56202 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. refactor code and add comments.

    @Benjamin2037
    Benjamin2037 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    9d2b142 View commit details
    Browse the repository at this point in the history

  2. add test case.

    @Benjamin2037
    Benjamin2037 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    4104176 View commit details
    Browse the repository at this point in the history

  3. add error information.

    @Benjamin2037
    Benjamin2037 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    43aae4c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-default-on-fast-ddl-ut-part2

    @Benjamin2037
    Benjamin2037 authored Nov 25, 2022
    Configuration menu
    Copy the full SHA
    8396fda View commit details
    Browse the repository at this point in the history

  5. Update ddl/index_merge_tmp_test.go 

    Co-authored-by: tangenta <tangenta@126.com>
    @Benjamin2037 @tangenta
    Benjamin2037 and tangenta authored Nov 25, 2022
    Configuration menu
    Copy the full SHA
    5c73ab3 View commit details
    Browse the repository at this point in the history

  6. remove reduent err check

    @Benjamin2037
    Benjamin2037 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    87e1d09 View commit details
    Browse the repository at this point in the history

  7. refactor code

    @Benjamin2037
    Benjamin2037 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    456b2bf View commit details
    Browse the repository at this point in the history

  8. refactor the code

    @Benjamin2037
    Benjamin2037 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    1f810bf View commit details
    Browse the repository at this point in the history

  9. unexported KeyInTempIndeix to keyInTempIndex

    @Benjamin2037
    Benjamin2037 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    10ecd3c View commit details
    Browse the repository at this point in the history

  10. name a enum tempIndexKeyState.

    @Benjamin2037
    Benjamin2037 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    928a07b View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Edit hook test case code.

    @Benjamin2037
    Benjamin2037 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    3778505 View commit details
    Browse the repository at this point in the history

  2. Add check logic to make sure the uk.newkey is from temp key, then app… 

    …ly check deleteu logic
    @Benjamin2037
    Benjamin2037 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    e37a755 View commit details
    Browse the repository at this point in the history

  3. Update ddl/index_merge_tmp_test.go 

    Co-authored-by: tangenta <tangenta@126.com>
    @Benjamin2037 @tangenta
    Benjamin2037 and tangenta authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    72886e7 View commit details
    Browse the repository at this point in the history

  4. Add check logic for input key and value.

    @Benjamin2037
    Benjamin2037 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    42f0e3e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'fix-default-on-fast-ddl-ut-part2' of github.com:Benjami… 

    …n2037/tidb into fix-default-on-fast-ddl-ut-part2
    @Benjamin2037
    Benjamin2037 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a16e7eb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into fix-default-on-fast-ddl-ut-part2

    @ti-chi-bot
    ti-chi-bot authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a4f2d55 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into fix-default-on-fast-ddl-ut-part2

    @ti-chi-bot
    ti-chi-bot authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d33e363 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into fix-default-on-fast-ddl-ut-part2

    @ti-chi-bot
    ti-chi-bot authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    125e94b View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into fix-default-on-fast-ddl-ut-part2

    @ti-chi-bot
    ti-chi-bot authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    9c370be View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into fix-default-on-fast-ddl-ut-part2

    @ti-chi-bot
    ti-chi-bot authored Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ef47ff7 View commit details
    Browse the repository at this point in the history