Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support read records with copr for adding index #39191

Merged
merged 10 commits into from
Nov 18, 2022
Merged

ddl: support read records with copr for adding index #39191

merged 10 commits into from
Nov 18, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 16, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #35983

Problem Summary:

What is changed and how it works?

This PR supports using coprocessor to read the table records for adding index.

Check List

Tests

The test is covered by realtikvtest/addindex.

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Defined2014
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2022
@tangenta tangenta mentioned this pull request Nov 16, 2022
Closed
20 tasks
Defined2014
Defined2014 reviewed Nov 17, 2022
View reviewed changes
Copy link
Contributor

@Defined2014 Defined2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a performance report in release note?

Defined2014
Defined2014 reviewed Nov 17, 2022
View reviewed changes
ddl/index_cop.go
return copCtx
}

func (c *copContext) buildTableScan(ctx context.Context, startTS uint64, start, end kv.Key) (distsql.SelectResult, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very like

tidb/ddl/reorg.go

Line 438 in 706a646

func (dc *ddlCtx) buildDescTableScan(ctx *JobContext, startTS uint64, tbl table.PhysicalTable,
, could we combine those two functions?

Copy link
Contributor Author

@tangenta tangenta Nov 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let's clean these up in another PR.

There are similar code in the following places:

  • (dc *ddlCtx) buildDescTableScan
  • (e *CheckIndexRangeExec) Open
  • (e *RecoverIndexExec) buildTableScan
  • (e *CleanupIndexExec) buildIndexScan

@tangenta
Copy link
Contributor Author

Could you add a performance report in release note?

The performance gets a little bit worse and unstable than the previous implementation, because this PR builds & sends the coprocessor requests multiple times for the same task range.

I would like to post the performance report in the next PR, which reuses the same coprocessor request and makes read and write asynchronize.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2022
@Benjamin2037
Copy link
Collaborator

@Benjamin2037 Benjamin2037 reopened this Nov 18, 2022
@tangenta
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2022
hawkingrei
hawkingrei reviewed Nov 18, 2022
View reviewed changes
ddl/index_cop_test.go
// See the License for the specific language governing permissions and
// limitations under the License.

package ddl_test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a new folder to put this test case? DDL put too much test cases in the folder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem?

Benjamin2037
Benjamin2037 approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2022
@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: abdf626

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2022
@ti-chi-bot ti-chi-bot merged commit e9253f7 into pingcap:master Nov 18, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Nov 18, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🔴 failed 1, success 38, total 39 19 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 10 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 9 min 36 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 6 min 15 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 4 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 45 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 4 min 27 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 37 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@Defined2014 Defined2014 deleted the add-index-copr-read branch November 18, 2022 12:38
@tangenta tangenta mentioned this pull request Nov 18, 2022
Merged
12 tasks
@tangenta tangenta mentioned this pull request Nov 23, 2022
Merged
12 tasks
@lcwangchao lcwangchao mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@Defined2014 Defined2014 Defined2014 approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tangenta @ti-chi-bot @Benjamin2037 @sre-bot @hawkingrei @wjhuang2016 @Defined2014