Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: set the keepalive MinTime for gRPC server #38987

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Nov 8, 2022

What problem does this PR solve?

Issue Number: close #38983

Problem Summary:

keepalive.EnforcementPolicy.MinTime is the minimum amount of time a client should wait before sending a keepalive ping. Currently, it is unset and the default value is 5 minutes, which is too long, since TopSQL gRPC client sends pings to the server every 10 seconds. As a result, "too many pings" is reported too frequently.

What is changed and how it works?

This PR changes this argument to 5 seconds.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • zhongzc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2022
@tangenta tangenta requested a review from zhongzc November 8, 2022 16:07
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2022
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 8, 2022
@bb7133 bb7133 closed this Nov 8, 2022
@bb7133 bb7133 reopened this Nov 8, 2022
@hawkingrei
Copy link
Member

/run-mysql-test

@hawkingrei
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3b2fa2a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2022
@ti-chi-bot ti-chi-bot merged commit c498090 into pingcap:master Nov 9, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38991.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38992.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #38993.

@sre-bot
Copy link
Contributor

sre-bot commented Nov 9, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/sqllogic-test-2 🟥 failed 2, success 26, total 28 8 min 4 sec New failing
idc-jenkins-ci-tidb/sqllogic-test-1 🟥 failed 2, success 24, total 26 5 min 5 sec New failing
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 3, success 3, total 6 44 min Existing failure
idc-jenkins-ci-tidb/mybatis-test 🔴 failed 1, success 0, total 1 11 min Existing failure
idc-jenkins-ci/integration-cdc-test ✅ all 39 tests passed 21 min Fixed
idc-jenkins-ci-tidb/common-test ✅ all 11 tests passed 17 min Fixed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 34 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 41 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got too many pings from the client
6 participants