-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: make "add foreign key" step in multiple schema versions #38679
Conversation
Signed-off-by: crazycs520 <crazycs520@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: crazycs520 <crazycs520@gmail.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3c3d2c0
|
@crazycs520: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
/run-all-tests |
/merge |
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
Issue Number: close #38678
At the same point in time, there may be two versions of the schema in the TiDB cluster, so we can't create foreign key in one schema version, since this may break foreign key constraint, such as delete reference table
without foreign key constrain check in child table.
So The DDL owner handle add foreign key constrain step should be:
write-only
into table.0
, otherwise, an error is returned and cancel the ddl job.public
.A problem is, How the DML treat the foreign key with on delete/update cascade behaviour which state is non-public?
Here is an example:
The schema change of foreign key
fk_1
is fromNone
->Write-Only
->Write-Reorg
->Public
。When the foreign key
fk_1
inWrite-Only
state, a DML request has come to be processed:Then, TiDB shouldn't do cascade delete for foreign key
fk_1
in stateWrite-Only
, since theAdd Foreign Key
DDL job maybefailed in
Write-Reorg
state and rollback the DDL job. But it is hard to rollback the cascade deleted executed before.So, when execute DML with
non-publick
foreign key, TiDB will do foreign key constraint check instead of foreign key cascade behaviour.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.