Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL: Remove TiFlash replica progress etcd dependency #38564

Merged
merged 23 commits into from
Oct 31, 2022
Merged

DDL: Remove TiFlash replica progress etcd dependency #38564

merged 23 commits into from
Oct 31, 2022

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented Oct 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #38464

Problem Summary:

What is changed and how it works?

Update TiFlash replica progress in the cache in DDL owner, avoiding the impact on ETCD in the case of many tables.
Send cop request to DDL owner to get TiFlash replica progress when query information_schema.tiflash_replica.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Create a table, set TiFlash replica, and then SELECT * FROM information_schema.tiflash_replica on two TiDB node, and do some restart operations at the same time.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2022
hehechen and others added 4 commits October 20, 2022 23:43
@hehechen
remove TiFlash progress etcd dependency
84b0201
must get progress
0c4778f 
Signed-off-by: hehechen <chentongli@pingcap.com>
delete from cache
ae65de2 
Signed-off-by: hehechen <chentongli@pingcap.com>
add ut
6dbbacb 
Signed-off-by: hehechen <chentongli@pingcap.com>
fix
e68b40a 
Signed-off-by: hehechen <chentongli@pingcap.com>
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 21, 2022
@hehechen
fix ut
04f037c 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen hehechen marked this pull request as ready for review October 21, 2022 08:09
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 21, 2022
@hehechen
Copy link
Contributor Author

/cc @breezewish @CalvinNeo @crazycs520

@hehechen
fix check-dev
c83c174 
Signed-off-by: hehechen <awd123456sss@gmail.com>
crazycs520
crazycs520 reviewed Oct 24, 2022
View reviewed changes
server/util.go Outdated Show resolved Hide resolved
address comment
51d8b56 
Signed-off-by: hehechen <chentongli@pingcap.com>
@hehechen
Copy link
Contributor Author

/run-build

@hehechen
Copy link
Contributor Author

/rebuild

fix format
65c9aec 
Signed-off-by: hehechen <chentongli@pingcap.com>
breezewish
breezewish reviewed Oct 25, 2022
View reviewed changes
domain/infosync/tiflash_manager.go Outdated Show resolved Hide resolved
domain/infosync/tiflash_manager.go Outdated Show resolved Hide resolved
executor/infoschema_reader.go Outdated Show resolved Hide resolved
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
planner/core/logical_plan_builder.go Outdated Show resolved Hide resolved
CalvinNeo
CalvinNeo approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Member

@CalvinNeo: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

breezewish
breezewish reviewed Oct 27, 2022
View reviewed changes
infoschema/cluster.go Show resolved Hide resolved
executor/table_reader.go Show resolved Hide resolved
executor/infoschema_reader.go Show resolved Hide resolved
infoschema/cluster.go Outdated Show resolved Hide resolved
infoschema/cluster.go Outdated Show resolved Hide resolved
domain/infosync/info.go Outdated Show resolved Hide resolved
domain/infosync/info.go Outdated Show resolved Hide resolved
@hehechen hehechen force-pushed the remove_etcd branch 3 times, most recently from 9d1d008 to ae83aaf Compare October 28, 2022 09:38
address comment
becf2dc 
Signed-off-by: hehechen <chentongli@pingcap.com>
hehechen added 2 commits October 28, 2022 18:00
Merge branch 'master' into remove_etcd
9d7ff19
fix progress decimal
b406585 
Signed-off-by: hehechen <chentongli@pingcap.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2022
hehechen and others added 3 commits October 28, 2022 19:02
fix conflict
a3407ea 
Signed-off-by: hehechen <chentongli@pingcap.com>
fix get storestats
eb84b7c 
Signed-off-by: hehechen <chentongli@pingcap.com>
@hehechen
Update info.go
755380f
breezewish
breezewish reviewed Oct 28, 2022
View reviewed changes
ddl/ddl_tiflash_api.go Outdated Show resolved Hide resolved
fix typo
52b34a6 
Signed-off-by: hehechen <chentongli@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 30, 2022
@hehechen
Copy link
Contributor Author

/run-unit-test

windtalker
windtalker approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 31, 2022
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 52b34a6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 31, 2022
@ti-chi-bot ti-chi-bot merged commit 8355181 into pingcap:master Oct 31, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Oct 31, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-ddl-test 🔴 failed 2, success 4, total 6 24 min Existing failure
idc-jenkins-ci-tidb/integration-common-test ✅ all 17 tests passed 9 min 44 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 38 tests passed 21 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 7 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 5 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 14 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 14 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 49 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@breezewish breezewish breezewish approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's no need to store TiFlash replica progress in ETCD.
8 participants
@hehechen @ti-chi-bot @wuhuizuo @breezewish @sre-bot @windtalker @CalvinNeo @crazycs520