-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: don't use DSN to avoid some security problems #38342
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@dwisiswant0 ptal. I didn't change some binaries that are only used in tests. |
/cc @kennytm not sure if you have interest in this problem |
PTAL @dwisiswant0 |
LGTM, @lance6716. I can confirm it can't be reproduced anymore.
|
/cc @lichunzhu ptal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: f1fb540
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-mysql-test |
TiDB MergeCI notify🔴 Bad News! [2] CI still failing after this pr merged.
|
/run-cherry-picker |
/run-cherry-picker |
In response to a cherrypick label: new pull request created: #38542. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
In response to a cherrypick label: new pull request created: #38543. |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Since it's already rolled out. Can you please give an update on 120f1346-e958-49d0-b66c-0f889a469540? Thanks. |
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: close #38541
--- copied from #37489 ---
Problem Summary:
TiDB uses Go MySQL Driver for connecting to MySQL servers. The Data Source Name (DSN) strings for describing database connections is not neutralized so they can escape and add new parameters to use as data source name.
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.