Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: add cache padding for lock of RowContainer #37627

Merged
merged 10 commits into from
Sep 7, 2022
Merged

executor: add cache padding for lock of RowContainer #37627

merged 10 commits into from
Sep 7, 2022

Conversation

gengliqi
Copy link
Contributor

@gengliqi gengliqi commented Sep 5, 2022 •
edited
Loading

Signed-off-by: gengliqi gengliqiii@gmail.com

What problem does this PR solve?

Issue Number: close #37641

Problem Summary:
As #37641 said, there are false sharing issue and true sharing issue of lock of RowContainer.
For the false sharing issue, this PR adds a cache padding for lock of RowContainer.
For the true sharing issue, this PR makes different workers use the different rlock.

Although the issue said we should find a more elegant method to solve this issue, @Yui-Song told me that the result of a certain test has a very unstable time which causes some warning reports. So it's better to solve this issue immediately.

We'll leave the reconstruction work to finish later.

Performance test by the complex query mentioned in #37641.

Master This PR
409.6s 190.4s
479.0s 189.9s
384.9s 189.7s

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Improve the performance of hash join in TiDB

@gengliqi
add cache padding for lock of RowCointainer
f597823 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 5, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2022
@gengliqi
Copy link
Contributor Author

gengliqi commented Sep 5, 2022

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Sep 5, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/506f1b659c20478053df43eab537df60472553e4/centos7/tidb-linux-arm64.tar.gz

@gengliqi gengliqi mentioned this pull request Sep 6, 2022
Closed
@gengliqi gengliqi marked this pull request as ready for review September 7, 2022 03:40
@gengliqi gengliqi changed the title WIP: add cache padding for lock of RowCointainer executor: add cache padding for lock of RowCointainer Sep 7, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2022
@gengliqi gengliqi changed the title executor: add cache padding for lock of RowCointainer executor: add cache padding for lock of RowContainer Sep 7, 2022
@gengliqi
Copy link
Contributor Author

gengliqi commented Sep 7, 2022

/cc @XuHuaiyu @wshwsh12

@XuHuaiyu XuHuaiyu added the type/enhancement The issue or PR belongs to an enhancement. label Sep 7, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2022
@XuHuaiyu XuHuaiyu added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@gengliqi
fix shallow pointer of mutexForRowContainer
1f1f0e1 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
Copy link
Contributor Author

gengliqi commented Sep 7, 2022

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Sep 7, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/1f1f0e1c853f10a1c07b9c4463fea8b5fe9b8f62/centos7/tidb-linux-arm64.tar.gz

@gengliqi
test without padding
3d3acbe 
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@gengliqi
Copy link
Contributor Author

gengliqi commented Sep 7, 2022

/run-build-arm64 comment=true

@sre-bot
Copy link
Contributor

sre-bot commented Sep 7, 2022

download tidb binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tidb/3d3acbe57d538f2aa4668b22ad0f3b5f016e034c/centos7/tidb-linux-arm64.tar.gz

@XuHuaiyu XuHuaiyu removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@dbsid
Copy link
Contributor

dbsid commented Sep 7, 2022

/run-build comment=true

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Sep 7, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e003638

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2022
@ti-chi-bot ti-chi-bot merged commit da05b4e into pingcap:master Sep 7, 2022
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 7, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Sep 7, 2022

TiDB MergeCI notify

🔴 Bad News! [2] CI still failing after this pr merged.
These failed integration tests don't seem to be introduced by the current PR.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 21 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 1, success 10, total 11 15 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 37 tests passed 28 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 8 min 53 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 8 min 29 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 20 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 16 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 43 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 9 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

XuHuaiyu added a commit to XuHuaiyu/tidb that referenced this pull request Dec 26, 2022
@XuHuaiyu
Revert "executor: add cache padding for lock of RowContainer (pingcap…
3fff806 
…#37627)"

This reverts commit da05b4e.
@XuHuaiyu XuHuaiyu mentioned this pull request Dec 26, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False & true sharing issue of RWMutex in mutexForRowContainer
6 participants
@gengliqi @ti-chi-bot @sre-bot @dbsid @XuHuaiyu @wshwsh12