Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: change graceful shutdown signal #37441

Merged
merged 4 commits into from
Aug 30, 2022
Merged

util: change graceful shutdown signal #37441

merged 4 commits into from
Aug 30, 2022

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Aug 29, 2022

Signed-off-by: xhe xw897002528@gmail.com

What problem does this PR solve?

Issue Number: close #13369

Problem Summary: TERM is a polite termination signal compared to QUIT or KILL. To keep compatibility, QUIT is also recognized as graceful. INT as a signal from the keyboard, is of course a graceful signal. HUP is somewhat special, it is kept as non-graceful as still.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    use kill command
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

SIGTERM, SIGQUIT, SIGINT will shutdown the server gracefully

@xhebox
util: change graceful shutdown signal
ff48a51 
Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 29, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 29, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/bccf19be561271d323694da411804de9b75b5edd

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 30, 2022
@wjhuang2016
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7ffb6c7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 30, 2022
@ti-chi-bot ti-chi-bot merged commit 4cece12 into pingcap:master Aug 30, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 30, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [1] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-compatibility-test 🟥 failed 1, success 0, total 1 3 min 31 sec New failing
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 2, success 15, total 17 19 min Existing failure
idc-jenkins-ci-tidb/common-test 🔴 failed 2, success 9, total 11 14 min Existing failure
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 7 min 58 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 8 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 4 min 51 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 21 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 39 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@xhebox xhebox mentioned this pull request Oct 21, 2022
Merged
12 tasks
july2993 added a commit that referenced this pull request Mar 6, 2023
@july2993
Keep the "graceful" behavior
9e086b9 
When graceful, keep waiting all connection drained.
When not, try 15s like before.
Note after #37441 the "graceful" or not checking is changed.
@july2993 july2993 mentioned this pull request Mar 6, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 27, 2023
Merged
12 tasks
@crazycs520 crazycs520 mentioned this pull request Nov 29, 2023
Merged
12 tasks
@xhebox xhebox deleted the signal branch April 7, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gracefully shutdown when receiving SIGTERM
5 participants
@xhebox @ti-chi-bot @sre-bot @wjhuang2016 @hawkingrei