Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: update plan cache key #36813

Merged
merged 10 commits into from
Aug 3, 2022
Merged

planner: update plan cache key #36813

merged 10 commits into from
Aug 3, 2022

Conversation

fzzf678
Copy link
Contributor

@fzzf678 fzzf678 commented Aug 2, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #36598

Problem Summary:
Update plan cache key, use more variables to form the key.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/7b355282f8909deb8bf82944505e0dff6cb5e4a8

@fzzf678 fzzf678 changed the title planner: update plan cache key and refactor the generateNewPlan function planner: update plan cache key Aug 3, 2022
@ti-chi-bot
Copy link
Member

@dayicklp: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzzf678
Copy link
Contributor Author

fzzf678 commented Aug 3, 2022

/cc @Reminiscent @qw4990

@fzzf678 fzzf678 marked this pull request as ready for review August 3, 2022 07:42
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@fzzf678
Copy link
Contributor Author

fzzf678 commented Aug 3, 2022

/cc @Reminiscent @qw4990

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2022
@Reminiscent
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b227623

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2022
@fzzf678
Copy link
Contributor Author

fzzf678 commented Aug 3, 2022

/run-build

@qw4990
Copy link
Contributor

qw4990 commented Aug 3, 2022

/merge

@fzzf678
Copy link
Contributor Author

fzzf678 commented Aug 3, 2022

/run-build

2 similar comments
@fzzf678
Copy link
Contributor Author

fzzf678 commented Aug 3, 2022

/run-build

@fzzf678
Copy link
Contributor Author

fzzf678 commented Aug 3, 2022

/run-build

@qw4990
Copy link
Contributor

qw4990 commented Aug 3, 2022

/merge

@Reminiscent Reminiscent mentioned this pull request Aug 3, 2022
Merged
12 tasks
@fzzf678
Copy link
Contributor Author

fzzf678 commented Aug 3, 2022

/merge

@ti-chi-bot
Copy link
Member

@fzzf678: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzzf678
Copy link
Contributor Author

fzzf678 commented Aug 3, 2022

/run-build

@fzzf678
Copy link
Contributor Author

fzzf678 commented Aug 3, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 43c1515 into pingcap:master Aug 3, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 3, 2022

TiDB MergeCI notify

🔴 Bad News! New failing [2] after this pr merged.
These new failed integration tests seem to be caused by the current PR, please try to fix these new failed integration tests, thanks!

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🟥 failed 3, success 14, total 17 20 min New failing
idc-jenkins-ci-tidb/integration-ddl-test 🟥 failed 1, success 5, total 6 9 min 30 sec New failing
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 34 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 15 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 11 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 8 min 44 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 8 min 16 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 32 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 25 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@dayicklp dayicklp dayicklp approved these changes

@Reminiscent Reminiscent Reminiscent approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fzzf678 @ti-chi-bot @sre-bot @Reminiscent @qw4990 @dayicklp