Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update pd-client to ensure tidb-server get clusterID correctly #36524

Merged
merged 3 commits into from
Jul 25, 2022
Merged

*: update pd-client to ensure tidb-server get clusterID correctly #36524

merged 3 commits into from
Jul 25, 2022

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Jul 25, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #36478, close #36505

Problem Summary: pd-client get clusterID equals to 0 caused tidb-server start failed.
I think the problem is caused by tikv/pd#5310, but the tikv/pd#5281 and tikv/pd#5310 already fixed this problem, so update pd-client is enough.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
start tiup playground with new tidb many times without any failed.
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

update pd-client

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hawkingrei
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 25, 2022
@Defined2014 Defined2014 changed the title pd-client: update pd-client to make sure get clusterID correct go.mod: update pd-client to make sure get clusterID correct Jul 25, 2022
@Defined2014 Defined2014 changed the title go.mod: update pd-client to make sure get clusterID correct go.mod: update pd-client to ensure tidb-server get clusterID correct Jul 25, 2022
@Defined2014 Defined2014 changed the title go.mod: update pd-client to ensure tidb-server get clusterID correct go.mod: update pd-client to ensure tidb-server get clusterID correctly Jul 25, 2022
@Defined2014 Defined2014 changed the title go.mod: update pd-client to ensure tidb-server get clusterID correctly *: update pd-client to ensure tidb-server get clusterID correctly Jul 25, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 25, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/e2c5ed703e5e5e5c80b18840282a1ff26bd8dd4a

hawkingrei
hawkingrei reviewed Jul 25, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 25, 2022
@Defined2014
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c423cb4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@ti-chi-bot ti-chi-bot merged commit e2f1ba9 into pingcap:master Jul 25, 2022
@Defined2014 Defined2014 deleted the update-pd-client branch July 25, 2022 12:41
@ti-srebot ti-srebot mentioned this pull request Jul 25, 2022
Merged
12 tasks
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jul 25, 2022
@Defined2014 @ti-srebot
cherry pick pingcap#36524 to release-6.2
1d2c050 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-6.2 in PR #36539

ti-chi-bot pushed a commit that referenced this pull request Jul 25, 2022
@ti-srebot
*: update pd-client to ensure tidb-server get clusterID correctly (…
fce3ceb 
…#36524) (#36539)

close #36478, close #36505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@sticnarf sticnarf Awaiting requested review from sticnarf

@xhebox xhebox Awaiting requested review from xhebox

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
6 participants
@Defined2014 @ti-chi-bot @sre-bot @ti-srebot @hawkingrei @xiongjiwei