Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: add index acceleration introduce sysvars and config param #36088

Merged
merged 11 commits into from
Aug 12, 2022
Merged

ddl: add index acceleration introduce sysvars and config param #36088

merged 11 commits into from
Aug 12, 2022

Conversation

Benjamin2037
Copy link
Collaborator

What problem does this PR solve?

Add sysvars and config parameter for add index acceleration.

Issue Number: ref #35983

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
None

@Benjamin2037 Benjamin2037 requested a review from a team as a code owner July 11, 2022 08:24
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • tangenta
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a169922a06f6794d166bc80f912ab6ee444b41d8

@Benjamin2037
Copy link
Collaborator Author

/run-check-dev-2

@Benjamin2037
Copy link
Collaborator Author

/run-check-dev

1 similar comment
@Benjamin2037
Copy link
Collaborator Author

/run-check-dev

@Benjamin2037
Copy link
Collaborator Author

/run-check-dev-2

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2022
@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_pr_add_sys_var branch from ad143af to 97ecfcd Compare July 19, 2022 09:58
@Benjamin2037
Copy link
Collaborator Author

/run-integration-br-test

@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_pr_add_sys_var branch from 6ab4514 to 939367f Compare July 25, 2022 06:11
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-integration-br-test

1 similar comment
@Benjamin2037
Copy link
Collaborator Author

/run-integration-br-test

tangenta
tangenta reviewed Jul 25, 2022
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
sessionctx/variable/tidb_vars.go Outdated Show resolved Hide resolved
sessionctx/variable/tidb_vars.go Outdated Show resolved Hide resolved
sessionctx/variable/sysvar_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 25, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2022
@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_pr_add_sys_var branch from d4cd636 to 1ed23b7 Compare August 1, 2022 09:46
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2022
@tangenta
Copy link
Contributor

tangenta commented Aug 1, 2022

/hold because the config is not decided yet.

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 1, 2022
@ti-chi-bot
Copy link
Member

@Benjamin2037: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tangenta
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2022
@tangenta tangenta removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 10, 2022
@tangenta tangenta changed the title DDL: Add index acceleration introduce sysvars and config param DDL: add index acceleration introduce sysvars and config param Aug 10, 2022
@tangenta tangenta changed the title DDL: add index acceleration introduce sysvars and config param ddl: add index acceleration introduce sysvars and config param Aug 10, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 10, 2022
@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 3507d09

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 12, 2022
@ti-chi-bot ti-chi-bot merged commit 323fdb2 into pingcap:master Aug 12, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Aug 12, 2022

TiDB MergeCI notify

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 17 tests passed 13 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 12 min Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 39 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 38 sec Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 5 min 28 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 4 min 18 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 8 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 3 min 0 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@dveeden dveeden mentioned this pull request Nov 3, 2022
Merged
13 tasks
This was referenced Nov 3, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@tangenta tangenta tangenta approved these changes

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@zimulala zimulala Awaiting requested review from zimulala

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Benjamin2037 @ti-chi-bot @sre-bot @tangenta @XuHuaiyu @xiongjiwei