Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: Preparation for add index acceleration #36085

Merged
merged 14 commits into from
Jul 28, 2022
Merged

ddl: Preparation for add index acceleration #36085

merged 14 commits into from
Jul 28, 2022

Conversation

Benjamin2037
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #35983

Problem Summary:
Do some br/lightning code refactor to solve import cycle problem.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • gozssky
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 11, 2022
@Benjamin2037
Copy link
Collaborator Author

/run unit-test

@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_pr_import_cycle branch from 942576d to fc1d005 Compare July 11, 2022 08:28
@sre-bot
Copy link
Contributor

sre-bot commented Jul 11, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/53b8756e5a07b9a52d594de51f9bc9eb7a28c333

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run check_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-check-dev

@Benjamin2037
Copy link
Collaborator Author

/run-build

@Benjamin2037
Copy link
Collaborator Author

/run-mysql-test

@hawkingrei
Copy link
Member

/run-chech_dev_2

@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

1 similar comment
@Benjamin2037
Copy link
Collaborator Author

/run-check_dev_2

sleepymole
sleepymole reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@sleepymole sleepymole left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this PR copy some files to solve import cycle problem. I think it's not a good practice. In this way, we need to maintain two copies of the same code.

br/pkg/lightning/backend/kv/kvtest/session_test.go Outdated Show resolved Hide resolved
br/pkg/conn/util/util.go Show resolved Hide resolved
br/pkg/lightning/backend/local/engine.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2022
@Benjamin2037 Benjamin2037 requested a review from a team as a code owner July 19, 2022 01:36
@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_pr_import_cycle branch 2 times, most recently from 4ed247b to 0b815e1 Compare July 19, 2022 02:15
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2022
@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_pr_import_cycle branch from 0b815e1 to 1b5d9b8 Compare July 19, 2022 09:00
@Benjamin2037
Copy link
Collaborator Author

I have refined the code.

@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_pr_import_cycle branch from 40b04e6 to af340d0 Compare July 19, 2022 11:37
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 28, 2022
@tangenta
Copy link
Contributor

Please resolve the conflicts.

@Benjamin2037 Benjamin2037 force-pushed the add_index_lightning_pr_import_cycle branch from 1f359cf to d3a6ed9 Compare July 28, 2022 07:36
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-integration-br-test

@tangenta
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d3a6ed9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 28, 2022
@Benjamin2037
Copy link
Collaborator Author

/run-integration-br-test

@ti-chi-bot ti-chi-bot merged commit 56dadec into pingcap:master Jul 28, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 28, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/integration-common-test 🔴 failed 1, success 16, total 17 20 min Existing failure
idc-jenkins-ci-tidb/integration-ddl-test ✅ all 6 tests passed 5 min 58 sec Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 36 tests passed 30 min Existing passed
idc-jenkins-ci-tidb/common-test 🟢 all 11 tests passed 19 min Existing passed
idc-jenkins-ci-tidb/tics-test 🟢 all 1 tests passed 9 min 55 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 37 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 11 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 4 min 25 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 3 min 27 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

@Benjamin2037 Benjamin2037 deleted the add_index_lightning_pr_import_cycle branch July 28, 2022 09:59
@tangenta tangenta mentioned this pull request Aug 1, 2022
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepymole sleepymole sleepymole approved these changes

@tangenta tangenta tangenta approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@zimulala zimulala Awaiting requested review from zimulala

@3pointer 3pointer Awaiting requested review from 3pointer

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Benjamin2037 @ti-chi-bot @sre-bot @hawkingrei @sleepymole @tangenta @3pointer