Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/copr: set low concurrency for keep order coprocessor requests #35975

Merged
merged 23 commits into from
Jul 17, 2022

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Jul 6, 2022

What problem does this PR solve?

Issue Number: close #35974

Problem Summary:

keep order requests consume much more memory than normal cases.
That's because we use a high coprocessor concurrency for it, but with the existance of 'order by',
the cop responses have to be handled one by one ... most of the cop responses are just wasting memory.

What is changed and how it works?

We don't need high concurrency for keep order coprocessor requests.

time mysql -h 127.0.0.1 -u root -P 4000 -B ens_rb -e 'set @@tidb_enable_paging = 1; select * from ens_rb.fm_acct_client_relation order by loginid' > /dev/null

=====================

The performance do not decrease with lower concurrency!

Before:

real	2m30.225s
user	1m33.578s
sys	0m8.454s

After:

real	2m32.266s
user	1m35.731s
sys	0m7.367s

=====================

The memory consumption reduced:

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Set a low concurrency value for coprocessor requests with 'keep order' property, this change can dramatically reduce the memory usage in a full table scan with 'order by' scenario 

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2022
@tiancaiamao tiancaiamao marked this pull request as ready for review July 6, 2022 04:10
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2022
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jul 6, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2022
@tiancaiamao
Copy link
Contributor Author

Testing with non-paging protocol, the conclusion is the same, high concurrency is useless here.

time mysql -h [127.0.0.1](http://127.0.0.1/) -u root -P 4000 -B ens_rb -e 'set @@tidb_enable_paging = 0; select * from ens_rb.fm_acct_client_relation order by loginid' > /dev/null

real	2m28.491s
user	1m35.039s
sys	0m7.399s

time mysql -h [127.0.0.1](http://127.0.0.1/) -u root -P 4000 -B ens_rb -e 'set @@tidb_enable_paging = 0; select * from ens_rb.fm_acct_client_relation order by loginid' > /dev/null

real	2m28.764s
user	1m35.245s
sys	0m7.526s

image

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 13, 2022
@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8f6ab49

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 14, 2022
@ti-chi-bot
Copy link
Member

@tiancaiamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@tiancaiamao
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2022
@tiancaiamao
Copy link
Contributor Author

/run-unit-test

@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 15, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jul 15, 2022

@tiancaiamao
Copy link
Contributor Author

/run-check_dev_2

1 similar comment
@tiancaiamao
Copy link
Contributor Author

/run-check_dev_2

@tiancaiamao
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2022
@tiancaiamao
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 74edaeb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scan full table using "order by" consume a lot of memory
6 participants